You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Leo Li (JIRA)" <ji...@apache.org> on 2006/12/15 13:16:23 UTC
[jira] Commented: (HARMONY-2680)
[classlib][security]AlgorithmParameters.getEncoded(null) throws
NullPointerException on Harmony but not on RI.
[ http://issues.apache.org/jira/browse/HARMONY-2680?page=comments#action_12458767 ]
Leo Li commented on HARMONY-2680:
---------------------------------
Hi, Stepan:
I think when to change the "null" to some other format such as "ASN1.x" , for example in the getEncoded() itself or delegate the issue to security provider is the detailed implementation. Furthermore, I think to throw NullPointerException is not acceptable since it is totally violating the spec and is of much more gravity than behaving like RI in mocking since actually we cannot behave just the same as RI unless we are another RI. :)
So I suggest to reopen the issue since at least we should obey spec.
> [classlib][security]AlgorithmParameters.getEncoded(null) throws NullPointerException on Harmony but not on RI.
> --------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-2680
> URL: http://issues.apache.org/jira/browse/HARMONY-2680
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Leo Li
> Assigned To: Stepan Mishura
> Attachments: patch-2680.diff
>
>
> Here is the testcase:
> public void test_algorithmParameters_getEncoded() throws Exception
> {
> AlgorithmParameters algorithmParameters = AlgorithmParameters.getInstance("DSA");
> algorithmParameters.init(new DSAParameterSpec(new BigInteger("23"), new BigInteger("19"), new BigInteger("2")));
> byte[] bytes1 = algorithmParameters.getEncoded(null);
> byte[] bytes2 = algorithmParameters.getEncoded();
> assertTrue(Arrays.equals(bytes1, bytes2));
> }
> RI passes.
> Harmony fails.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira