You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/08 01:23:27 UTC

[GitHub] [arrow-rs] HaoYang670 commented on a diff in pull request #2000: Add Decimal256Builder and Decimal256Array

HaoYang670 commented on code in PR #2000:
URL: https://github.com/apache/arrow-rs/pull/2000#discussion_r916386516


##########
arrow/src/array/builder/decimal_builder.rs:
##########
@@ -42,8 +44,18 @@ pub struct DecimalBuilder {
     value_validation: bool,
 }
 
+/// Array Builder for [`Decimal256Array`]
+///
+/// See [`Decimal256Array`] for example.
+#[derive(Debug)]
+pub struct Decimal256Builder {
+    builder: FixedSizeListBuilder<UInt8Builder>,

Review Comment:
   It may be more straightforward to build decimal array based on `FixedSizeBinaryBuilder`. I will file a followup issue.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org