You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "Yunyung (via GitHub)" <gi...@apache.org> on 2024/11/01 08:07:34 UTC
[PR] KAFKA-17919: enable back the failing testShareGroups test [kafka]
Yunyung opened a new pull request, #17658:
URL: https://github.com/apache/kafka/pull/17658
JIRA: https://issues.apache.org/jira/browse/KAFKA-17919
I have looped the test 40 times on my local, all pass.
Command:
`I=0; while ./gradlew core:test --tests PlaintextAdminIntegrationTest.testShareGroups --rerun --fail-fast; do (( I=$I+1 )); echo "Completed run: $I"; sleep 1; done`
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17919: enable back the failing testShareGroups test [kafka]
Posted by "AndrewJSchofield (via GitHub)" <gi...@apache.org>.
AndrewJSchofield commented on PR #17658:
URL: https://github.com/apache/kafka/pull/17658#issuecomment-2452209050
The test is still flaky, with the same symptom, but a different reason. The fix in https://github.com/apache/kafka/pull/17656 looks good, but there is more to it. I would say there's a timing problem in initialization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17919: enable back the failing testShareGroups test [kafka]
Posted by "apoorvmittal10 (via GitHub)" <gi...@apache.org>.
apoorvmittal10 commented on PR #17658:
URL: https://github.com/apache/kafka/pull/17658#issuecomment-2452105694
> Yes, it's the same NOT_COORDINATOR error. I ran it extensively on 2 computers yesterday and it was clean on both. The CI and everyone else's testing also appears clean. However, on my third computer today, I get the same failure. I don't understand why, yet.
The other doubt I had was NOT_COORDINATOR is a retriable exception hence should we retry as part of https://github.com/apache/kafka/pull/17645 (ofcourse it was not the right fix for testShareGroups test but not sure why a retriable exception is not retried)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17919: enable back the failing testShareGroups test [kafka]
Posted by "AndrewJSchofield (via GitHub)" <gi...@apache.org>.
AndrewJSchofield commented on PR #17658:
URL: https://github.com/apache/kafka/pull/17658#issuecomment-2451992059
Yes, it's the same NOT_COORDINATOR error. I ran it extensively on 2 computers yesterday and it was clean on both. The CI and everyone else's testing also appears clean. However, on my third computer today, I get the same failure. I don't understand why, yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17919: enable back the failing testShareGroups test [kafka]
Posted by "AndrewJSchofield (via GitHub)" <gi...@apache.org>.
AndrewJSchofield commented on PR #17658:
URL: https://github.com/apache/kafka/pull/17658#issuecomment-2452258944
When https://github.com/apache/kafka/pull/17645 is merged, then I think the test will be properly deflaked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17919: enable back the failing testShareGroups test [kafka]
Posted by "AndrewJSchofield (via GitHub)" <gi...@apache.org>.
AndrewJSchofield commented on PR #17658:
URL: https://github.com/apache/kafka/pull/17658#issuecomment-2451878619
I think I had another failure of this test. Let's be careful here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17919: enable back the failing testShareGroups test [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 merged PR #17658:
URL: https://github.com/apache/kafka/pull/17658
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17919: enable back the failing testShareGroups test [kafka]
Posted by "apoorvmittal10 (via GitHub)" <gi...@apache.org>.
apoorvmittal10 commented on PR #17658:
URL: https://github.com/apache/kafka/pull/17658#issuecomment-2451899348
> I think I had another failure of this test. Let's be careful here.
Do you mean after the fix you did, this test is again flaky? Is it the same NOT_COORDINATOR error?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17919: enable back the failing testShareGroups test [kafka]
Posted by "Yunyung (via GitHub)" <gi...@apache.org>.
Yunyung commented on PR #17658:
URL: https://github.com/apache/kafka/pull/17658#issuecomment-2452757854
Thanks for both clarifying and explaining this. Let's wait until #17645 is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org