You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/10/23 14:03:07 UTC
[GitHub] [shardingsphere] RaigorJiang opened a new pull request, #21705: For #21698, change `migration process configuration` to `migration rule`.
RaigorJiang opened a new pull request, #21705:
URL: https://github.com/apache/shardingsphere/pull/21705
Fixes #21698.
Changes proposed in this pull request:
- Change `ALTER MIGRATION PROCESS CONFIGURATION` to `ALTER MIGRATION RULE`.
- Change `SHOW MIGRATION PROCESS CONFIGURATION` to `SHOW MIGRATION RULE`.
- Remove syntax `CREATE MIGRATION PROCESS CONFIGURATION`
- Remove syntax `DROP MIGRATION PROCESS CONFIGURATION`
---
Before committing this PR, I'm sure that I have checked the following options:
- [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [x] I have self-reviewed the commit code.
- [x] I have (or in comment I request) added corresponding labels for the pull request.
- [x] I have passed maven check locally : `mvn clean install -B -T2C -DskipTests -Dmaven.javadoc.skip=true -e`.
- [x] I have made corresponding changes to the documentation.
- [x] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #21705: For #21698, change `migration process configuration` to `migration rule`.
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #21705:
URL: https://github.com/apache/shardingsphere/pull/21705#issuecomment-1288140073
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/21705?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#21705](https://codecov.io/gh/apache/shardingsphere/pull/21705?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fd824df) into [master](https://codecov.io/gh/apache/shardingsphere/commit/63f8a4f297b15910ee3d69cf167235272da010bc?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (63f8a4f) will **increase** coverage by `0.01%`.
> The diff coverage is `20.00%`.
```diff
@@ Coverage Diff @@
## master #21705 +/- ##
============================================
+ Coverage 61.02% 61.03% +0.01%
+ Complexity 2505 2502 -3
============================================
Files 4111 4107 -4
Lines 57375 57349 -26
Branches 9696 9693 -3
============================================
- Hits 35013 35004 -9
+ Misses 19455 19438 -17
Partials 2907 2907
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/21705?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ser/core/kernel/KernelDistSQLStatementVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/21705/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGlzdHNxbC9wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2Rpc3RzcWwvcGFyc2VyL2NvcmUva2VybmVsL0tlcm5lbERpc3RTUUxTdGF0ZW1lbnRWaXNpdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...i/impl/AbstractInventoryIncrementalJobAPIImpl.java](https://codecov.io/gh/apache/shardingsphere/pull/21705/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS9jb3JlL2FwaS9pbXBsL0Fic3RyYWN0SW52ZW50b3J5SW5jcmVtZW50YWxKb2JBUElJbXBsLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...pdatable/AlterInventoryIncrementalRuleUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/21705/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmFsL3VwZGF0YWJsZS9BbHRlckludmVudG9yeUluY3JlbWVudGFsUnVsZVVwZGF0ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...crementalProcessConfigurationSegmentConverter.java](https://codecov.io/gh/apache/shardingsphere/pull/21705/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmFsL3VwZGF0YWJsZS9jb252ZXJ0ZXIvSW52ZW50b3J5SW5jcmVtZW50YWxQcm9jZXNzQ29uZmlndXJhdGlvblNlZ21lbnRDb252ZXJ0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | |
| [.../migration/UpdatableScalingRALStatementAssert.java](https://codecov.io/gh/apache/shardingsphere/pull/21705/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Rlc3Qvc3FsL3BhcnNlci9wYXJhbWV0ZXJpemVkL2Fzc2VydHMvc3RhdGVtZW50L2Rpc3RzcWwvcmFsL2ltcGwvbWlncmF0aW9uL1VwZGF0YWJsZVNjYWxpbmdSQUxTdGF0ZW1lbnRBc3NlcnQuamF2YQ==) | `94.11% <ø> (-0.62%)` | :arrow_down: |
| [...eterized/jaxb/cases/domain/SQLParserTestCases.java](https://codecov.io/gh/apache/shardingsphere/pull/21705/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Rlc3Qvc3FsL3BhcnNlci9wYXJhbWV0ZXJpemVkL2pheGIvY2FzZXMvZG9tYWluL1NRTFBhcnNlclRlc3RDYXNlcy5qYXZh) | `99.31% <ø> (-0.01%)` | :arrow_down: |
| [...ral/queryable/ShowMigrationRuleQueryResultSet.java](https://codecov.io/gh/apache/shardingsphere/pull/21705/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmFsL3F1ZXJ5YWJsZS9TaG93TWlncmF0aW9uUnVsZVF1ZXJ5UmVzdWx0U2V0LmphdmE=) | `26.66% <100.00%> (ø)` | |
| [...handler/distsql/ral/hint/enums/HintSourceType.java](https://codecov.io/gh/apache/shardingsphere/pull/21705/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmFsL2hpbnQvZW51bXMvSGludFNvdXJjZVR5cGUuamF2YQ==) | `0.00% <0.00%> (-42.86%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu merged pull request #21705: For #21698, change `migration process configuration` to `migration rule`.
Posted by GitBox <gi...@apache.org>.
terrymanu merged PR #21705:
URL: https://github.com/apache/shardingsphere/pull/21705
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org