Re: svn commit: r1033320 - in /subversion/trunk/subversion: include/svn_error_codes.h svn/cl.h svn/export-cmd.c svn/notify.c svn/switch-cmd.c svn/update-cmd.c tests/cmdline/externals_tests.py

[Noorul Islam K M <no...@collab.net>]

cmpilato@apache.org writes:

> Author: cmpilato
> Date: Wed Nov 10 01:44:35 2010
> New Revision: 1033320
>
> URL: http://svn.apache.org/viewvc?rev=1033320&view=rev
> Log:
> Fix issue #3622 ("svn should exit with exit code 1 if updating
> externals fails").
>
> * subversion/include/svn_error_codes.h
>   (SVN_ERR_CL_ERROR_PROCESSING_EXTERNALS): New error code.
>  
> * subversion/svn/cl.h
>   (struct svn_cl__check_externals_failed_notify_baton): New baton.
>   (svn_cl__check_externals_failed_notify_wrapper): New function.
>
> * subversion/svn/notify.c
>   (svn_cl__check_externals_failed_notify_wrapper): New function.
>
> * subversion/svn/update-cmd.c
>   (svn_cl__update): Use the new wrapper baton and function to track
>     externals processing failures, and return an error after all else
>     is finished if such failures occured.
>
> * subversion/svn/export-cmd.c
>   (svn_cl__export): Use the new wrapper baton and function to track
>     externals processing failures, and return an error after all else
>     is finished if such failures occured.
>
> * subversion/svn/switch-cmd.c
>   (svn_cl__switch): Use the new wrapper baton and function to track
>     externals processing failures, and return an error after all else
>     is finished if such failures occured.
>
> * subversion/tests/cmdline/externals_tests.py
>   (old_style_externals_ignore_peg_reg,
>    can_place_file_external_into_dir_external): Change expected exit code.
>
> Modified:
>     subversion/trunk/subversion/include/svn_error_codes.h
>     subversion/trunk/subversion/svn/cl.h
>     subversion/trunk/subversion/svn/export-cmd.c
>     subversion/trunk/subversion/svn/notify.c
>     subversion/trunk/subversion/svn/switch-cmd.c
>     subversion/trunk/subversion/svn/update-cmd.c
>     subversion/trunk/subversion/tests/cmdline/externals_tests.py
>

I think I can have similar approach for issue 3713. If you are not
already on it then I will try implementing the same for 3713.

Thanks and Regards
Noorul

Re: svn commit: r1033320 - in /subversion/trunk/subversion: include/svn_error_codes.h svn/cl.h svn/export-cmd.c svn/notify.c svn/switch-cmd.c svn/update-cmd.c tests/cmdline/externals_tests.py

["C. Michael Pilato" <cm...@collab.net>]

On 11/09/2010 10:30 PM, Noorul Islam K M wrote:
> I think I can have similar approach for issue 3713. If you are not
> already on it then I will try implementing the same for 3713.

Nope, I'm not "on it".

-- 
C. Michael Pilato <cm...@collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand