You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "kacpermuda (via GitHub)" <gi...@apache.org> on 2025/06/24 13:35:30 UTC
[PR] feat: Add explicit support for SnowflakeSqlApiHook to Ol helper [airflow]
kacpermuda opened a new pull request, #52161:
URL: https://github.com/apache/airflow/pull/52161
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
Waiting for #52157 to be merged.
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Add explicit support for SnowflakeSqlApiHook to Ol helper [airflow]
Posted by "kacpermuda (via GitHub)" <gi...@apache.org>.
kacpermuda commented on code in PR #52161:
URL: https://github.com/apache/airflow/pull/52161#discussion_r2174764869
##########
providers/snowflake/src/airflow/providers/snowflake/utils/openlineage.py:
##########
@@ -204,9 +205,29 @@ def _run_single_query_with_hook(hook: SnowflakeHook, sql: str) -> list[dict]:
return result
+def _run_single_query_with_api_hook(hook: SnowflakeSqlApiHook, sql: str) -> list[dict[str, Any]]:
+ """Execute a query against Snowflake API without adding extra logging or instrumentation."""
+ # `hook.execute_query` resets the query_ids, so we need to save them and re-assign after we're done
+ query_ids_before_execution = list(hook.query_ids)
+ try:
+ _query_ids = hook.execute_query(sql=sql, statement_count=0)
+ hook.wait_for_query(query_id=_query_ids[0], raise_error=True, poll_interval=1, timeout=3)
+ return hook.get_result_from_successful_sql_api_query(query_id=_query_ids[0])
+ finally:
+ hook.query_ids = query_ids_before_execution
Review Comment:
I thought about it, or even just adding a simple `reset_query_id: bool = True` arg to the `execute_query`, but I think this is a very rare case, where you want to run some query but still want to keep old query_ids after execution. I've decided that this edge case, that can be easily worked around with try/finally should not complicate the logic of code in the hook. I'm open to changing that if you think that this can be useful for the end users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Add explicit support for SnowflakeSqlApiHook to Ol helper [airflow]
Posted by "mobuchowski (via GitHub)" <gi...@apache.org>.
mobuchowski merged PR #52161:
URL: https://github.com/apache/airflow/pull/52161
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Add explicit support for SnowflakeSqlApiHook to Ol helper [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #52161:
URL: https://github.com/apache/airflow/pull/52161#issuecomment-3015985902
rebasing to account for compat tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Add explicit support for SnowflakeSqlApiHook to Ol helper [airflow]
Posted by "mobuchowski (via GitHub)" <gi...@apache.org>.
mobuchowski commented on code in PR #52161:
URL: https://github.com/apache/airflow/pull/52161#discussion_r2174705185
##########
providers/snowflake/src/airflow/providers/snowflake/utils/openlineage.py:
##########
@@ -204,9 +205,29 @@ def _run_single_query_with_hook(hook: SnowflakeHook, sql: str) -> list[dict]:
return result
+def _run_single_query_with_api_hook(hook: SnowflakeSqlApiHook, sql: str) -> list[dict[str, Any]]:
+ """Execute a query against Snowflake API without adding extra logging or instrumentation."""
+ # `hook.execute_query` resets the query_ids, so we need to save them and re-assign after we're done
+ query_ids_before_execution = list(hook.query_ids)
+ try:
+ _query_ids = hook.execute_query(sql=sql, statement_count=0)
+ hook.wait_for_query(query_id=_query_ids[0], raise_error=True, poll_interval=1, timeout=3)
+ return hook.get_result_from_successful_sql_api_query(query_id=_query_ids[0])
+ finally:
+ hook.query_ids = query_ids_before_execution
Review Comment:
Wouldn't it be better to move the raw `execute_query` logic into something like internal `_execute_query` and keep the `query_ids` behavior, but just call the `_` version when you don't want to store the query id?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org