[GitHub] [cassandra] smiklosovic commented on a change in pull request #844: CASSANDRA-16331 Extend the exclusion of replica filtering protection to other indices instead of just SASI

[GitBox <gi...@apache.org>]

smiklosovic commented on a change in pull request #844:
URL: https://github.com/apache/cassandra/pull/844#discussion_r538702151



##########
File path: src/java/org/apache/cassandra/index/Index.java
##########
@@ -426,6 +426,16 @@ public Indexer indexerFor(DecoratedKey key,
                               WriteContext ctx,
                               IndexTransaction.Type transactionType);
 
+    /**
+     * Tells whether this index supports replica fitering protection or not.
+     *
+     * @return true if this index supports replica filtering protection, false otherwise
+     */
+    default boolean supportsReplicaFilteringProtection()

Review comment:
       I dont agree with `supportsFiltering`, it is pretty non-telling ... like filtering of what? I would go with this name as is, without `IndexFeature` as argument. Deal? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org