You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@griffin.apache.org by GitBox <gi...@apache.org> on 2019/09/16 02:58:08 UTC

[GitHub] [griffin] wankunde commented on a change in pull request #534: [GRIFFIN-290]Fix bug for submitting job to livy

wankunde commented on a change in pull request #534: [GRIFFIN-290]Fix bug for submitting job to livy
URL: https://github.com/apache/griffin/pull/534#discussion_r324499467
 
 

 ##########
 File path: service/src/main/java/org/apache/griffin/core/job/SparkSubmitJob.java
 ##########
 @@ -204,6 +204,7 @@ private void setLivyArgs() throws IOException {
         args.add(finalMeasureJson);
         args.add("raw,raw");
         livyConfMap.put("args", args);
+        livyConfMap.remove("name");
 
 Review comment:
   @guoyuepeng 
   Instead of hard coding,we can explicitly specify the livy session name in the  configuration file. which is null by default.
   
   Or we can use the DQ job name to be the livy session name?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services