You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by britter <gi...@git.apache.org> on 2016/10/09 13:43:39 UTC
[GitHub] maven-surefire pull request #126: Make Junit4VersionsIT parameterized
GitHub user britter opened a pull request:
https://github.com/apache/maven-surefire/pull/126
Make Junit4VersionsIT parameterized
In preparation for introducing more JUnit 5 ITs, make the Junit4VersionsIT parameterized.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/britter/maven-surefire junit4-versions
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/maven-surefire/pull/126.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #126
----
commit e619e7ff44990142a6b61367cebc95908a1ddf91
Author: Benedikt Ritter <br...@apache.org>
Date: 2016-10-09T13:38:44Z
Make Junit4VersionsIT a parameterized test
commit fa086e0853b9729725690694875114440ad8890a
Author: Benedikt Ritter <br...@apache.org>
Date: 2016-10-09T13:40:55Z
Add missing JUnit 4 versions to Junit4VersionsIT
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire issue #126: Make Junit4VersionsIT parameterized
Posted by britter <gi...@git.apache.org>.
Github user britter commented on the issue:
https://github.com/apache/maven-surefire/pull/126
@Tibor17 Wouldn't it be better to rebase junit5 branch onto master? I don't have push access to maven-surefire, so you would have to do the trick.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire issue #126: Make Junit4VersionsIT parameterized
Posted by britter <gi...@git.apache.org>.
Github user britter commented on the issue:
https://github.com/apache/maven-surefire/pull/126
We need to rebase the junit5 branch after this has been merged in order to pick up this changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire issue #126: Make Junit4VersionsIT parameterized
Posted by Tibor17 <gi...@git.apache.org>.
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/126
@britter
Done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire issue #126: Make Junit4VersionsIT parameterized
Posted by Tibor17 <gi...@git.apache.org>.
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/126
@britter
The only problem is with workspace for the `Junit4VersionsIT` which is `/target/Junit4VersionsIT_testJunit` same for all parameters. Therefore we should not take the only single parameter for `unpack( "/junit4" );`. There should be used a suffix as the second parameter which segregates the workspaces by parameterized runner.
You may fix it in a new PR. This would be helpful in order we want to download a zip of workspaces in Jenkins.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire pull request #126: Make Junit4VersionsIT parameterized
Posted by britter <gi...@git.apache.org>.
Github user britter closed the pull request at:
https://github.com/apache/maven-surefire/pull/126
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire issue #126: Make Junit4VersionsIT parameterized
Posted by britter <gi...@git.apache.org>.
Github user britter commented on the issue:
https://github.com/apache/maven-surefire/pull/126
Okay, this is reintegrated. I will fix it in another PR. Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire issue #126: Make Junit4VersionsIT parameterized
Posted by Tibor17 <gi...@git.apache.org>.
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/126
@britter
Finally please merge master to junit5 branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org