You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/12/06 12:50:18 UTC

[GitHub] [pulsar-client-cpp] shibd commented on a diff in pull request #138: Boost optional

shibd commented on code in PR #138:
URL: https://github.com/apache/pulsar-client-cpp/pull/138#discussion_r1040929848


##########
lib/ConsumerImpl.cc:
##########
@@ -512,7 +512,7 @@ void ConsumerImpl::messageReceived(const ClientConnectionPtr& cnx, const proto::
         m.impl_->convertPayloadToKeyValue(config_.getSchema());
 
         const auto startMessageId = startMessageId_.get();
-        if (isPersistent_ && startMessageId.is_present() &&
+        if (isPersistent_ && startMessageId.has_value() &&

Review Comment:
   Uniform style:
   ```suggestion
           if (isPersistent_ && startMessageId &&
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org