[GitHub] [maven-resolver] cstamas commented on a diff in pull request #249: [MRESOLVER-314] IAEx thrown when sorting versions with hex values

["cstamas (via GitHub)" <gi...@apache.org>]

cstamas commented on code in PR #249:
URL: https://github.com/apache/maven-resolver/pull/249#discussion_r1109403798


##########
maven-resolver-util/src/test/java/org/eclipse/aether/util/version/GenericVersionTest.java:
##########
@@ -349,6 +354,39 @@ public void testMaximumSegment()
 
     /**
      * UT for <a href="https://issues.apache.org/jira/browse/MRESOLVER-314">MRESOLVER-314</a>.
+     *
+     * Generates random UUID string based versions and tries to sort them. While this test is not as reliable
+     * as {@link #testCompareUuidVersionStringStream()}, it covers broader range and in case it fails it records
+     * the failed array, so we can investigate more.
+     */
+    @Test
+    public void testCompareUuidRandom() {

Review Comment:
   Is that junit4?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org