[jira] Commented: (CASSANDRA-214) Incorrect parameter names in Thrift interface

["Jun Rao (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12716337#action_12716337 ] 

Jun Rao commented on CASSANDRA-214:
-----------------------------------

The patch looks fine.

Now that we are on Thrift api. 
3:string columnFamily_column in get_slice is also confusing. In a regular CF, the parameter should be just CF. In a super CF, the parameter could also be CF_superColumn. Neither matches the current parameter name. Since most users are likely on regular CF, may be we should rename 3 to just columnFamily? 

Similarly, I propose changing 3:string columnFamily_column in get_column_count to just columnFamily.
 

> Incorrect parameter names in Thrift interface
> ---------------------------------------------
>
>                 Key: CASSANDRA-214
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-214
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 0.3
>            Reporter: Thorsten von Eicken
>            Assignee: Jonathan Ellis
>            Priority: Minor
>         Attachments: 214.patch
>
>
> The Thrift interface is incorrect as follows. This does not affect correctnes, it just makes it hard to understand the operations.
> The Thrift interface for get_superColumn is incorrect. It seems to me that "3:string columnFamily" should really be "3:string columnFamily_superColumnName" (I know this doesn't have any functional impact, just makes it hard to understand what the operation does)
> The Thrift interface for get_slice_super is incorrect. It seems to me that "3:string columnFamily_superColumnName" should really be "3:string columnFamily"

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.