You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@opennlp.apache.org by Jörn Kottmann <ko...@gmail.com> on 2013/10/07 16:11:10 UTC
Re: svn commit: r1529520 - /opennlp/trunk/opennlp-tools/src/main/java/opennlp/tools/entitylinker/MySQLGeoNamesGazLinkable.java
Please always reference the issue number as part of the commit log message.
Jörn
On 10/05/2013 11:20 PM, markg@apache.org wrote:
> Author: markg
> Date: Sat Oct 5 21:20:53 2013
> New Revision: 1529520
>
> URL: http://svn.apache.org/r1529520
> Log:
> Was not using the EntityLinkerProperties passed in. Now fixed.
>
> Modified:
> opennlp/trunk/opennlp-tools/src/main/java/opennlp/tools/entitylinker/MySQLGeoNamesGazLinkable.java
>
> Modified: opennlp/trunk/opennlp-tools/src/main/java/opennlp/tools/entitylinker/MySQLGeoNamesGazLinkable.java
> URL: http://svn.apache.org/viewvc/opennlp/trunk/opennlp-tools/src/main/java/opennlp/tools/entitylinker/MySQLGeoNamesGazLinkable.java?rev=1529520&r1=1529519&r2=1529520&view=diff
> ==============================================================================
> --- opennlp/trunk/opennlp-tools/src/main/java/opennlp/tools/entitylinker/MySQLGeoNamesGazLinkable.java (original)
> +++ opennlp/trunk/opennlp-tools/src/main/java/opennlp/tools/entitylinker/MySQLGeoNamesGazLinkable.java Sat Oct 5 21:20:53 2013
> @@ -4,7 +4,6 @@ package opennlp.tools.entitylinker;
> *
> * @author Owner
> */
> -import java.io.File;
> import java.sql.CallableStatement;
> import java.sql.Connection;
> import java.sql.DriverManager;
> @@ -56,8 +55,8 @@ public final class MySQLGeoNamesGazLinka
> return returnlocs;
> }
>
> - protected Connection getMySqlConnection(EntityLinkerProperties properties) throws Exception {
> - EntityLinkerProperties property = new EntityLinkerProperties(new File("c:\\temp\\opennlpmodels\\entitylinker.properties"));
> + protected Connection getMySqlConnection(EntityLinkerProperties property) throws Exception {
> + // EntityLinkerProperties property = new EntityLinkerProperties(new File("c:\\temp\\opennlpmodels\\entitylinker.properties"));
> String driver = property.getProperty("mysql.driver", "org.gjt.mm.mysql.Driver");
> String url = property.getProperty("mysql.url", "jdbc:mysql://localhost:3306/world");
> String username = property.getProperty("mysql.username", "root");
>
>
Re: svn commit: r1529520 - /opennlp/trunk/opennlp-tools/src/main/java/opennlp/tools/entitylinker/MySQLGeoNamesGazLinkable.java
Posted by Mark G <gi...@gmail.com>.
got it
On Mon, Oct 7, 2013 at 10:11 AM, Jörn Kottmann <ko...@gmail.com> wrote:
> Please always reference the issue number as part of the commit log message.
>
> Jörn
>
>
> On 10/05/2013 11:20 PM, markg@apache.org wrote:
>
>> Author: markg
>> Date: Sat Oct 5 21:20:53 2013
>> New Revision: 1529520
>>
>> URL: http://svn.apache.org/r1529520
>> Log:
>> Was not using the EntityLinkerProperties passed in. Now fixed.
>>
>> Modified:
>> opennlp/trunk/opennlp-tools/**src/main/java/opennlp/tools/**
>> entitylinker/**MySQLGeoNamesGazLinkable.java
>>
>> Modified: opennlp/trunk/opennlp-tools/**src/main/java/opennlp/tools/**
>> entitylinker/**MySQLGeoNamesGazLinkable.java
>> URL: http://svn.apache.org/viewvc/**opennlp/trunk/opennlp-tools/**
>> src/main/java/opennlp/tools/**entitylinker/**
>> MySQLGeoNamesGazLinkable.java?**rev=1529520&r1=1529519&r2=**
>> 1529520&view=diff<http://svn.apache.org/viewvc/opennlp/trunk/opennlp-tools/src/main/java/opennlp/tools/entitylinker/MySQLGeoNamesGazLinkable.java?rev=1529520&r1=1529519&r2=1529520&view=diff>
>> ==============================**==============================**
>> ==================
>> --- opennlp/trunk/opennlp-tools/**src/main/java/opennlp/tools/**
>> entitylinker/**MySQLGeoNamesGazLinkable.java (original)
>> +++ opennlp/trunk/opennlp-tools/**src/main/java/opennlp/tools/**
>> entitylinker/**MySQLGeoNamesGazLinkable.java Sat Oct 5 21:20:53 2013
>> @@ -4,7 +4,6 @@ package opennlp.tools.entitylinker;
>> *
>> * @author Owner
>> */
>> -import java.io.File;
>> import java.sql.CallableStatement;
>> import java.sql.Connection;
>> import java.sql.DriverManager;
>> @@ -56,8 +55,8 @@ public final class MySQLGeoNamesGazLinka
>> return returnlocs;
>> }
>> - protected Connection getMySqlConnection(**EntityLinkerProperties
>> properties) throws Exception {
>> - EntityLinkerProperties property = new EntityLinkerProperties(new
>> File("c:\\temp\\opennlpmodels\**\entitylinker.properties"));
>> + protected Connection getMySqlConnection(**EntityLinkerProperties
>> property) throws Exception {
>> + // EntityLinkerProperties property = new EntityLinkerProperties(new
>> File("c:\\temp\\opennlpmodels\**\entitylinker.properties"));
>> String driver = property.getProperty("mysql.**driver",
>> "org.gjt.mm.mysql.Driver");
>> String url = property.getProperty("mysql.**url",
>> "jdbc:mysql://localhost:3306/**world");
>> String username = property.getProperty("mysql.**username", "root");
>>
>>
>>
>