You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by breakdawn <gi...@git.apache.org> on 2016/03/15 11:28:38 UTC
[GitHub] spark pull request: [SPARK-13397] Cleanup transient annotations wh...
GitHub user breakdawn opened a pull request:
https://github.com/apache/spark/pull/11727
[SPARK-13397] Cleanup transient annotations which aren't being applied
## What changes were proposed in this pull request?
This cleanup the transient annotations which aren't being applied. The followings are the warnings
GSchedulerSuite.scala:70: no valid targets for annotation on value tracker - it is discarded unused. You may specify targets with meta-annotations, e.g. @(transient @param)
@transient tracker: MapOutputTrackerMaster = null)
SerializationDebuggerSuite.scala:222: no valid targets for annotation on value replacementFieldObject - it is discarded unused. You may specify targets with meta-annotations, e.g. @(transient @param)
class SerializableClassWithWriteReplace(@transient replacementFieldObject: Object)
ReceiverTrackerSuite.scala:108: no valid targets for annotation on value _ssc - it is discarded unused. You may specify targets with meta-annotations, e.g. @(transient @param)
class RateTestInputDStream(@transient _ssc: StreamingContext)
## How was this patch tested?
Manual.
During building, there should be no warning on transient annotation unused.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/breakdawn/spark master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/11727.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #11727
----
commit 26fb355083e7a5215c421a7218cc8f23aedb8d2c
Author: Wesley Tang <ta...@mininglamp.com>
Date: 2016-03-15T09:15:45Z
[SPARK-13397] Cleanup transient annotations which aren't being applied
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13397] Cleanup transient annotations wh...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11727#issuecomment-196758568
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13397] Cleanup transient annotations wh...
Posted by breakdawn <gi...@git.apache.org>.
Github user breakdawn closed the pull request at:
https://github.com/apache/spark/pull/11727
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13397] Cleanup transient annotations wh...
Posted by breakdawn <gi...@git.apache.org>.
Github user breakdawn commented on the pull request:
https://github.com/apache/spark/pull/11727#issuecomment-196787205
I agree that the third annotation can be removed, the reason is the base class DStream has marked it as transient anyway.
By the way, should i close this PR since it's covered by [#11725](https://github.com/apache/spark/pull/11725)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13397] Cleanup transient annotations wh...
Posted by breakdawn <gi...@git.apache.org>.
Github user breakdawn commented on the pull request:
https://github.com/apache/spark/pull/11727#issuecomment-196791813
That's fine, maybe next time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13397] Cleanup transient annotations wh...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/11727#issuecomment-196788327
Yeah sorry we had a bit of a race condition here. I submitted the PR just before this, and actually didn't realize there was a whole separate JIRA for this one issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13397] Cleanup transient annotations wh...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/11727#issuecomment-196758277
This is covered by https://github.com/apache/spark/pull/11725 I agree with the changes, except that I think that in the third instance the annotation actually won't make a difference and should be removed. The superclass retains a non-transient reference anyway.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org