You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2016/02/01 20:41:05 UTC
Re: Review Request 42615: mesos: Cleaned up usage of
namespace-qualified identifiers.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42615/
-----------------------------------------------------------
(Updated Feb. 1, 2016, 7:40 p.m.)
Review request for mesos and Michael Park.
Changes
-------
Rebase, more minor fixes.
Repository: mesos
Description
-------
For example, avoid using `std::string` in a .cpp file that already does
`using std::string`.
Diffs (updated)
-----
src/authentication/http/basic_authenticator_factory.cpp 6eb1c5bd09b136d3bc20481ddcc65cb8bd153682
src/cli/execute.cpp 0add77558e07ff49f0134ddb9085509501c61aab
src/common/http.cpp b7e71eb79ccb8ef1d0bbd168d77d4d4591ecb09b
src/common/protobuf_utils.cpp 53324ab569751924f25290641d1a70da790c2104
src/docker/docker.cpp a83172674b385a59cfd6f344836740a5719f954e
src/examples/balloon_framework.cpp 3c17676c92f72d41c501b2435a7017e3c9f01278
src/examples/test_container_logger_module.cpp 6b1f4dbd63145afe4de17830c0a2a6202a896be7
src/examples/test_http_authenticator_module.cpp acf51a6deb8e7dc4ab6ac0cf70380ddbb1839906
src/examples/test_qos_controller_module.cpp f8aa1d730f6cdf5ab3f11789e9699682cc08ddd5
src/files/files.cpp dd64976ca454786152a8e29f590e8c1ed1df3b54
src/health-check/main.cpp 0beaed575ec865d81e6e3d83d8a0c894613acba4
src/hook/manager.cpp 6ee93038dce1247cffbc82c736a1c7a1ecb84bb0
src/launcher/fetcher.cpp 902e927ce0cbcf70e41041375e61987752629957
src/linux/routing/queueing/fq_codel.cpp d840e383f28481ba58d8269217a8a194c4e87db5
src/linux/routing/queueing/ingress.cpp c25a93966caca5c5a9eef91e6caa5d9e29091bee
src/linux/systemd.cpp d3f4a63d833a5bc599494e925d709ba0cc70d9ec
src/local/local.cpp 582d4a10444831b0753d20650698e5d3b51cca9f
src/log/tool/initialize.cpp c9706d1e33659f7b0e375419197b207cb96d4ca9
src/log/tool/read.cpp 9abf5a82338c554920283e0329cd83e4c787c103
src/log/tool/replica.cpp 8baf79755da420cf594d706f31aa561b5d665051
src/master/allocator/mesos/hierarchical.cpp 1a07d69016407e5aad2209586da37fecbcddb765
src/master/allocator/sorter/drf/sorter.cpp db47d640e36c0302d7c6254a9c58caa878feac01
src/master/main.cpp 7ebca788c35d5bb6898ae65df91b899c2b74f3d4
src/master/maintenance.cpp df7cd6ca5a097611e5ca5a46cc988ef636da096b
src/master/master.cpp 98441a543611d4083b2495ee103f0ab5e2187e83
src/module/manager.cpp a53f71b9965f7ab85aadb6c0c7af18de958faf38
src/slave/containerizer/docker.cpp 2887cb4a01febbbf276026e584ffc466289e10c9
src/slave/containerizer/fetcher.cpp f7e3f7de6d0ebc253d2ccfe4a66b10ed2eca2c11
src/slave/containerizer/mesos/linux_launcher.cpp 61801fffe9bac1a995a57d8b4e8c004d624bbd63
src/slave/containerizer/mesos/provisioner/docker/paths.cpp 9c5c24992f9ea36159271691cca0147851240088
src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp b74c760e90b12f5bf45b6e626e2b661f841e5a8d
src/slave/containerizer/mesos/provisioner/docker/store.cpp 71caeca9005b5846c56ff4dfd260b426958a73c5
src/slave/paths.cpp 77e86a07b7c64775d1cb1542527cdfc38b6748ff
src/slave/qos_controllers/load.cpp 52520d6220784423c09001b8bd59e090ebf787ec
src/slave/state.cpp fae7738a1cb7168abc0cfe35b075bbc73306b820
src/tests/attributes_tests.cpp 3f3dde1301566f279c3fc7dc24e3ef67039a4c14
src/tests/common/http_tests.cpp 0ea06341b092cd6ad278075b12dd970b84c84464
src/tests/containerizer/cgroups_isolator_tests.cpp 0d24809701c42dc036bbd051791545f4742d1e9a
src/tests/containerizer/cgroups_tests.cpp 5e15d44a472b2acd64475f69fd44cd4d2d9f729d
src/tests/containerizer/external_containerizer_test.cpp da52860f4a1d5363d7b61b9a8bb6abad02d89736
src/tests/containerizer/provisioner_docker_tests.cpp de99126aca8dccea0b4c04f975e4da4710b5a1f1
src/tests/credentials_tests.cpp 6e3725c61a55a2c1d183ee278cf3d72be16a6e40
src/tests/fetcher_cache_tests.cpp 2747b72ba49c9fde04e556b649601b037517283e
src/tests/gc_tests.cpp ef5544b627ac4a9f9c13fe13b0c51b21d5b98a12
src/tests/hierarchical_allocator_tests.cpp f18e6eb10572b0f5b8bbff338384d9406f6ad62b
src/tests/hook_tests.cpp 1a1bab49469485887e0a6a8fa1837bd70262d3b5
src/tests/http_authentication_tests.cpp bd622576973648e0dfeae1453a5ce631e4171352
src/tests/master_quota_tests.cpp 04efcf3362d3594e0ad8077793fa1f32536dd658
src/tests/mesos.cpp 18d0d8f8037ebc27c87bcb0f1ce9f143e7505ec8
src/tests/monitor_tests.cpp 2226458b59b4a279a92e1353bd61457a0018d2a9
src/tests/registrar_tests.cpp 58b3fccf5450d20032c5c6d20d76dbd868c424a3
src/tests/registrar_zookeeper_tests.cpp 3861dcf8341bfa520f94fd244b4814827299b861
src/tests/scheduler_driver_tests.cpp f35c4957b08803dba924ebf1a5f0af9daac9d0c5
src/tests/slave_tests.cpp ede2df08c2a9f7e1f010ff9dccbea0a1e94af55f
src/tests/values_tests.cpp a4eb68ad13407f471a07a9a923ed31c7890da9f7
src/uri/fetchers/curl.cpp 269df874f3a3a65d045a0822af57ba65e23a9fe0
src/watcher/whitelist_watcher.cpp 14d7de751884d4734942e315e61a94c29868ff4b
src/zookeeper/detector.cpp a3d68c12e3800805a35f9bb05e7689830eedbae6
Diff: https://reviews.apache.org/r/42615/diff/
Testing
-------
"make check" on OSX and Arch Linux.
Thanks,
Neil Conway
Re: Review Request 42615: Cleaned up usage of namespace-qualified
identifiers in Mesos.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42615/#review117744
-----------------------------------------------------------
Fix it, then Ship it!
src/cli/execute.cpp (lines 201 - 203)
<https://reviews.apache.org/r/42615/#comment179026>
```cpp
foreachpair (
const string& name, const string& value, environment.get())
```
src/docker/docker.cpp (lines 385 - 386)
<https://reviews.apache.org/r/42615/#comment179027>
```cpp
const vector<string> tokens =
strings::tokenize(value.as<JSON::String>().value, "=");
```
- Michael Park
On Feb. 1, 2016, 10:07 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42615/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2016, 10:07 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> For example, avoid using `std::string` in a .cpp file that already does
> `using std::string`.
>
>
> Diffs
> -----
>
> src/authentication/http/basic_authenticator_factory.cpp 6eb1c5bd09b136d3bc20481ddcc65cb8bd153682
> src/cli/execute.cpp 0add77558e07ff49f0134ddb9085509501c61aab
> src/common/http.cpp b7e71eb79ccb8ef1d0bbd168d77d4d4591ecb09b
> src/common/protobuf_utils.cpp 53324ab569751924f25290641d1a70da790c2104
> src/docker/docker.cpp a83172674b385a59cfd6f344836740a5719f954e
> src/examples/balloon_framework.cpp 3c17676c92f72d41c501b2435a7017e3c9f01278
> src/examples/test_container_logger_module.cpp 6b1f4dbd63145afe4de17830c0a2a6202a896be7
> src/examples/test_http_authenticator_module.cpp acf51a6deb8e7dc4ab6ac0cf70380ddbb1839906
> src/examples/test_qos_controller_module.cpp f8aa1d730f6cdf5ab3f11789e9699682cc08ddd5
> src/files/files.cpp dd64976ca454786152a8e29f590e8c1ed1df3b54
> src/health-check/main.cpp 0beaed575ec865d81e6e3d83d8a0c894613acba4
> src/hook/manager.cpp 6ee93038dce1247cffbc82c736a1c7a1ecb84bb0
> src/launcher/fetcher.cpp 902e927ce0cbcf70e41041375e61987752629957
> src/linux/routing/queueing/fq_codel.cpp d840e383f28481ba58d8269217a8a194c4e87db5
> src/linux/routing/queueing/ingress.cpp c25a93966caca5c5a9eef91e6caa5d9e29091bee
> src/linux/systemd.cpp d3f4a63d833a5bc599494e925d709ba0cc70d9ec
> src/local/local.cpp 582d4a10444831b0753d20650698e5d3b51cca9f
> src/log/tool/initialize.cpp c9706d1e33659f7b0e375419197b207cb96d4ca9
> src/log/tool/read.cpp 9abf5a82338c554920283e0329cd83e4c787c103
> src/log/tool/replica.cpp 8baf79755da420cf594d706f31aa561b5d665051
> src/master/allocator/mesos/hierarchical.cpp 1a07d69016407e5aad2209586da37fecbcddb765
> src/master/allocator/sorter/drf/sorter.cpp db47d640e36c0302d7c6254a9c58caa878feac01
> src/master/main.cpp 7ebca788c35d5bb6898ae65df91b899c2b74f3d4
> src/master/maintenance.cpp df7cd6ca5a097611e5ca5a46cc988ef636da096b
> src/master/master.cpp 98441a543611d4083b2495ee103f0ab5e2187e83
> src/module/manager.cpp a53f71b9965f7ab85aadb6c0c7af18de958faf38
> src/slave/containerizer/docker.cpp 2887cb4a01febbbf276026e584ffc466289e10c9
> src/slave/containerizer/fetcher.cpp f7e3f7de6d0ebc253d2ccfe4a66b10ed2eca2c11
> src/slave/containerizer/mesos/linux_launcher.cpp 61801fffe9bac1a995a57d8b4e8c004d624bbd63
> src/slave/containerizer/mesos/provisioner/docker/paths.cpp 9c5c24992f9ea36159271691cca0147851240088
> src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp b74c760e90b12f5bf45b6e626e2b661f841e5a8d
> src/slave/containerizer/mesos/provisioner/docker/store.cpp 71caeca9005b5846c56ff4dfd260b426958a73c5
> src/slave/paths.cpp 77e86a07b7c64775d1cb1542527cdfc38b6748ff
> src/slave/qos_controllers/load.cpp 52520d6220784423c09001b8bd59e090ebf787ec
> src/slave/state.cpp fae7738a1cb7168abc0cfe35b075bbc73306b820
> src/tests/attributes_tests.cpp 3f3dde1301566f279c3fc7dc24e3ef67039a4c14
> src/tests/common/http_tests.cpp 0ea06341b092cd6ad278075b12dd970b84c84464
> src/tests/containerizer/cgroups_isolator_tests.cpp 0d24809701c42dc036bbd051791545f4742d1e9a
> src/tests/containerizer/cgroups_tests.cpp 5e15d44a472b2acd64475f69fd44cd4d2d9f729d
> src/tests/containerizer/external_containerizer_test.cpp da52860f4a1d5363d7b61b9a8bb6abad02d89736
> src/tests/containerizer/provisioner_docker_tests.cpp de99126aca8dccea0b4c04f975e4da4710b5a1f1
> src/tests/credentials_tests.cpp 6e3725c61a55a2c1d183ee278cf3d72be16a6e40
> src/tests/fetcher_cache_tests.cpp 2747b72ba49c9fde04e556b649601b037517283e
> src/tests/gc_tests.cpp ef5544b627ac4a9f9c13fe13b0c51b21d5b98a12
> src/tests/hierarchical_allocator_tests.cpp f18e6eb10572b0f5b8bbff338384d9406f6ad62b
> src/tests/hook_tests.cpp 1a1bab49469485887e0a6a8fa1837bd70262d3b5
> src/tests/http_authentication_tests.cpp bd622576973648e0dfeae1453a5ce631e4171352
> src/tests/master_quota_tests.cpp 04efcf3362d3594e0ad8077793fa1f32536dd658
> src/tests/mesos.cpp 18d0d8f8037ebc27c87bcb0f1ce9f143e7505ec8
> src/tests/monitor_tests.cpp 2226458b59b4a279a92e1353bd61457a0018d2a9
> src/tests/registrar_tests.cpp 58b3fccf5450d20032c5c6d20d76dbd868c424a3
> src/tests/registrar_zookeeper_tests.cpp 3861dcf8341bfa520f94fd244b4814827299b861
> src/tests/scheduler_driver_tests.cpp f35c4957b08803dba924ebf1a5f0af9daac9d0c5
> src/tests/slave_tests.cpp ede2df08c2a9f7e1f010ff9dccbea0a1e94af55f
> src/tests/values_tests.cpp a4eb68ad13407f471a07a9a923ed31c7890da9f7
> src/uri/fetchers/curl.cpp 269df874f3a3a65d045a0822af57ba65e23a9fe0
> src/watcher/whitelist_watcher.cpp 14d7de751884d4734942e315e61a94c29868ff4b
> src/zookeeper/detector.cpp a3d68c12e3800805a35f9bb05e7689830eedbae6
>
> Diff: https://reviews.apache.org/r/42615/diff/
>
>
> Testing
> -------
>
> "make check" on OSX and Arch Linux.
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 42615: Cleaned up usage of namespace-qualified
identifiers in Mesos.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42615/
-----------------------------------------------------------
(Updated Feb. 1, 2016, 10:07 p.m.)
Review request for mesos and Michael Park.
Changes
-------
Fix commit message style
Summary (updated)
-----------------
Cleaned up usage of namespace-qualified identifiers in Mesos.
Repository: mesos
Description
-------
For example, avoid using `std::string` in a .cpp file that already does
`using std::string`.
Diffs (updated)
-----
src/authentication/http/basic_authenticator_factory.cpp 6eb1c5bd09b136d3bc20481ddcc65cb8bd153682
src/cli/execute.cpp 0add77558e07ff49f0134ddb9085509501c61aab
src/common/http.cpp b7e71eb79ccb8ef1d0bbd168d77d4d4591ecb09b
src/common/protobuf_utils.cpp 53324ab569751924f25290641d1a70da790c2104
src/docker/docker.cpp a83172674b385a59cfd6f344836740a5719f954e
src/examples/balloon_framework.cpp 3c17676c92f72d41c501b2435a7017e3c9f01278
src/examples/test_container_logger_module.cpp 6b1f4dbd63145afe4de17830c0a2a6202a896be7
src/examples/test_http_authenticator_module.cpp acf51a6deb8e7dc4ab6ac0cf70380ddbb1839906
src/examples/test_qos_controller_module.cpp f8aa1d730f6cdf5ab3f11789e9699682cc08ddd5
src/files/files.cpp dd64976ca454786152a8e29f590e8c1ed1df3b54
src/health-check/main.cpp 0beaed575ec865d81e6e3d83d8a0c894613acba4
src/hook/manager.cpp 6ee93038dce1247cffbc82c736a1c7a1ecb84bb0
src/launcher/fetcher.cpp 902e927ce0cbcf70e41041375e61987752629957
src/linux/routing/queueing/fq_codel.cpp d840e383f28481ba58d8269217a8a194c4e87db5
src/linux/routing/queueing/ingress.cpp c25a93966caca5c5a9eef91e6caa5d9e29091bee
src/linux/systemd.cpp d3f4a63d833a5bc599494e925d709ba0cc70d9ec
src/local/local.cpp 582d4a10444831b0753d20650698e5d3b51cca9f
src/log/tool/initialize.cpp c9706d1e33659f7b0e375419197b207cb96d4ca9
src/log/tool/read.cpp 9abf5a82338c554920283e0329cd83e4c787c103
src/log/tool/replica.cpp 8baf79755da420cf594d706f31aa561b5d665051
src/master/allocator/mesos/hierarchical.cpp 1a07d69016407e5aad2209586da37fecbcddb765
src/master/allocator/sorter/drf/sorter.cpp db47d640e36c0302d7c6254a9c58caa878feac01
src/master/main.cpp 7ebca788c35d5bb6898ae65df91b899c2b74f3d4
src/master/maintenance.cpp df7cd6ca5a097611e5ca5a46cc988ef636da096b
src/master/master.cpp 98441a543611d4083b2495ee103f0ab5e2187e83
src/module/manager.cpp a53f71b9965f7ab85aadb6c0c7af18de958faf38
src/slave/containerizer/docker.cpp 2887cb4a01febbbf276026e584ffc466289e10c9
src/slave/containerizer/fetcher.cpp f7e3f7de6d0ebc253d2ccfe4a66b10ed2eca2c11
src/slave/containerizer/mesos/linux_launcher.cpp 61801fffe9bac1a995a57d8b4e8c004d624bbd63
src/slave/containerizer/mesos/provisioner/docker/paths.cpp 9c5c24992f9ea36159271691cca0147851240088
src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp b74c760e90b12f5bf45b6e626e2b661f841e5a8d
src/slave/containerizer/mesos/provisioner/docker/store.cpp 71caeca9005b5846c56ff4dfd260b426958a73c5
src/slave/paths.cpp 77e86a07b7c64775d1cb1542527cdfc38b6748ff
src/slave/qos_controllers/load.cpp 52520d6220784423c09001b8bd59e090ebf787ec
src/slave/state.cpp fae7738a1cb7168abc0cfe35b075bbc73306b820
src/tests/attributes_tests.cpp 3f3dde1301566f279c3fc7dc24e3ef67039a4c14
src/tests/common/http_tests.cpp 0ea06341b092cd6ad278075b12dd970b84c84464
src/tests/containerizer/cgroups_isolator_tests.cpp 0d24809701c42dc036bbd051791545f4742d1e9a
src/tests/containerizer/cgroups_tests.cpp 5e15d44a472b2acd64475f69fd44cd4d2d9f729d
src/tests/containerizer/external_containerizer_test.cpp da52860f4a1d5363d7b61b9a8bb6abad02d89736
src/tests/containerizer/provisioner_docker_tests.cpp de99126aca8dccea0b4c04f975e4da4710b5a1f1
src/tests/credentials_tests.cpp 6e3725c61a55a2c1d183ee278cf3d72be16a6e40
src/tests/fetcher_cache_tests.cpp 2747b72ba49c9fde04e556b649601b037517283e
src/tests/gc_tests.cpp ef5544b627ac4a9f9c13fe13b0c51b21d5b98a12
src/tests/hierarchical_allocator_tests.cpp f18e6eb10572b0f5b8bbff338384d9406f6ad62b
src/tests/hook_tests.cpp 1a1bab49469485887e0a6a8fa1837bd70262d3b5
src/tests/http_authentication_tests.cpp bd622576973648e0dfeae1453a5ce631e4171352
src/tests/master_quota_tests.cpp 04efcf3362d3594e0ad8077793fa1f32536dd658
src/tests/mesos.cpp 18d0d8f8037ebc27c87bcb0f1ce9f143e7505ec8
src/tests/monitor_tests.cpp 2226458b59b4a279a92e1353bd61457a0018d2a9
src/tests/registrar_tests.cpp 58b3fccf5450d20032c5c6d20d76dbd868c424a3
src/tests/registrar_zookeeper_tests.cpp 3861dcf8341bfa520f94fd244b4814827299b861
src/tests/scheduler_driver_tests.cpp f35c4957b08803dba924ebf1a5f0af9daac9d0c5
src/tests/slave_tests.cpp ede2df08c2a9f7e1f010ff9dccbea0a1e94af55f
src/tests/values_tests.cpp a4eb68ad13407f471a07a9a923ed31c7890da9f7
src/uri/fetchers/curl.cpp 269df874f3a3a65d045a0822af57ba65e23a9fe0
src/watcher/whitelist_watcher.cpp 14d7de751884d4734942e315e61a94c29868ff4b
src/zookeeper/detector.cpp a3d68c12e3800805a35f9bb05e7689830eedbae6
Diff: https://reviews.apache.org/r/42615/diff/
Testing
-------
"make check" on OSX and Arch Linux.
Thanks,
Neil Conway