[jira] Commented: (HDFS-1252) TestDFSConcurrentFileOperations broken in 0.20-appendj

["sam rash (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-1252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12892444#action_12892444 ] 

sam rash commented on HDFS-1252:
--------------------------------

does the patch preserver the essence of the test: a file that is about to be closed is moved and lease recovery should still work (ie, recover blocks that are already finalized on DNs)


> TestDFSConcurrentFileOperations broken in 0.20-appendj
> ------------------------------------------------------
>
>                 Key: HDFS-1252
>                 URL: https://issues.apache.org/jira/browse/HDFS-1252
>             Project: Hadoop HDFS
>          Issue Type: Test
>          Components: test
>    Affects Versions: 0.20-append
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 0.20-append
>
>         Attachments: hdfs-1252.txt
>
>
> This test currently has several flaws:
>  - It calls DN.updateBlock with a BlockInfo instance, which then causes java.lang.RuntimeException: java.lang.NoSuchMethodException: org.apache.hadoop.hdfs.server.namenode.BlocksMap$BlockInfo.<init>() in the logs when the DN tries to send blockReceived for the block
>  - It assumes that getBlockLocations returns an up-to-date length block after a sync, which is false. It happens to work because it calls getBlockLocations directly on the NN, and thus gets a direct reference to the block in the blockmap, which later gets updated
> This patch fixes this test to use the AppendTestUtil functions to intiiate recovery, and generally pass more reliably.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.