You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "bonsairobo (via GitHub)" <gi...@apache.org> on 2025/09/25 19:28:58 UTC
[PR] fix(azblob): don't call AzureStorageConfig::from_env on wasm [opendal]
bonsairobo opened a new pull request, #6594:
URL: https://github.com/apache/opendal/pull/6594
# Which issue does this PR close?
Closes https://github.com/apache/opendal/issues/6593
# What changes are included in this PR?
Gated the `AzblobConfig::from_env` behind a `#[cfg(not(target_arch = "wasm32"))]`
# Are there any user-facing changes?
No. I don't believe the functionality of loading the azblob backend from environment variables can ever work in the browser.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(azblob): don't call AzureStorageConfig::from_env on wasm [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #6594:
URL: https://github.com/apache/opendal/pull/6594
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(azblob): don't call AzureStorageConfig::from_env on wasm [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #6594:
URL: https://github.com/apache/opendal/pull/6594#issuecomment-3352297810
> It would be awesome if we could add a CI test similar to `s3_read_on_wasm` for azblob. Is that desirable for this PR? Anything I should know before trying to implement that?
It think it's better to have a new PR for that, thank you in advance!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(azblob): don't call AzureStorageConfig::from_env on wasm [opendal]
Posted by "bonsairobo (via GitHub)" <gi...@apache.org>.
bonsairobo commented on PR #6594:
URL: https://github.com/apache/opendal/pull/6594#issuecomment-3335655679
It would be awesome if we could add a CI test similar to `s3_read_on_wasm` for azblob. Is that desirable for this PR? Anything I should know before trying to implement that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org