You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/10/21 10:05:39 UTC

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #329: [FLINK-28157] Table Store Hive Reader supports Hive3

JingsongLi commented on code in PR #329:
URL: https://github.com/apache/flink-table-store/pull/329#discussion_r1001612616


##########
flink-table-store-hive/flink-table-store-hive-connector/src/test/java/org/apache/flink/table/store/hive/TableStoreHiveStorageHandlerITCase.java:
##########
@@ -894,18 +895,18 @@ public void testDateAndTimestamp() throws Exception {
                                 "STORED BY '" + TableStoreHiveStorageHandler.class.getName() + "'",
                                 "LOCATION '" + path + "'")));
         Assert.assertEquals(
-                Collections.singletonList("1971-01-11\t2022-05-17 17:29:20.0"),

Review Comment:
   Modify test data to `.1`, because hive3 will produce `17:29:20` for `17:29:20.0`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org