[GitHub] [arrow] marsupialtail commented on a diff in pull request #13385: ARROW-16521 [C++][R] Configure curl timeout policy for S3

[GitBox <gi...@apache.org>]

marsupialtail commented on code in PR #13385:
URL: https://github.com/apache/arrow/pull/13385#discussion_r899244896


##########
cpp/src/arrow/filesystem/s3fs.cc:
##########
@@ -701,6 +701,17 @@ class ClientBuilder {
     if (!options_.region.empty()) {
       client_config_.region = ToAwsString(options_.region);
     }
+    if (options_.request_timeout_ms != -1) {
+      client_config_.requestTimeoutMs = options_.request_timeout_ms;

Review Comment:
   At least it works on Mac for me... I'm not sure why the documentation says it's windows-specific. will look into this. I am aware that on this: https://sdk.amazonaws.com/cpp/api/LATEST/struct_aws_1_1_client_1_1_client_configuration.html it says its windows specific, but the official docs don't mention anything about that: https://docs.aws.amazon.com/sdk-for-cpp/v1/developer-guide/client-config.html



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org