[GitHub] sijie opened a new pull request #1218: Support LacPiggyback, LongPoll and ExplicitLac in db ledger storage

[GitBox <gi...@apache.org>]

sijie opened a new pull request #1218: Support LacPiggyback, LongPoll and ExplicitLac in db ledger storage
URL: https://github.com/apache/bookkeeper/pull/1218
 
 
   Descriptions of the changes in this PR:
   
   *Motivation*
   
   DbLedgerStorage was developed in yahoo and just merged recently to master. This implementation only works for v2 protocol.
   It doesn't work with v3 protocol. When using v3 protocol clients (e.g. dlog library) to talk to bookies use DbLedgerStorage,
   the clients hang on waiting responses. because a few methods in DbLedgerStorage throw UnsupportedException
   
   *Solution*
   
   This change focuses on adding the implementations for those methods, in order to support LacPiggyback, LongPoll and ExplicitLac
   for v3 protocol. The implementation follows what we had in FileInfoCache but did it in a much simpler way, since all the persistence
   information has been managed by db ledger storage itself. All the information required by `LacPiggyback`, `LongPoll` and `ExplicitLac`
   are transient.
   
   This change doesn't introduce any new test cases. It reuses existing test cases to test those features using DbLedgerStorage. These
   tests are:
   
   - ExplicitLacTest: for testing explicit lac
   - TestPiggybackLAC: for testing piggback lac
   - TestReadLastConfirmedLongPoll: for testing long polling lac
   - TestReadLastConfirmedAndEntry: for testing entry piggyback
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services