You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2022/02/12 11:19:49 UTC
svn commit: r1897996 - /pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/shading/PDShadingType5.java
Author: tilman
Date: Sat Feb 12 11:19:49 2022
New Revision: 1897996
URL: http://svn.apache.org/viewvc?rev=1897996&view=rev
Log:
PDFBOX-4892: refactor long method
Modified:
pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/shading/PDShadingType5.java
Modified: pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/shading/PDShadingType5.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/shading/PDShadingType5.java?rev=1897996&r1=1897995&r2=1897996&view=diff
==============================================================================
--- pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/shading/PDShadingType5.java (original)
+++ pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/shading/PDShadingType5.java Sat Feb 12 11:19:49 2022
@@ -137,13 +137,12 @@ public class PDShadingType5 extends PDTr
mciis.close();
}
int rowNum = vlist.size() / numPerRow;
- Vertex[][] latticeArray = new Vertex[rowNum][numPerRow];
- List<ShadedTriangle> list = new ArrayList<ShadedTriangle>();
if (rowNum < 2)
{
// must have at least two rows; if not, return empty list
- return list;
+ return Collections.emptyList();
}
+ Vertex[][] latticeArray = new Vertex[rowNum][numPerRow];
for (int i = 0; i < rowNum; i++)
{
for (int j = 0; j < numPerRow; j++)
@@ -152,8 +151,14 @@ public class PDShadingType5 extends PDTr
}
}
+ return createShadedTriangleList(rowNum, numPerRow, latticeArray);
+ }
+
+ private List<ShadedTriangle> createShadedTriangleList(int rowNum, int numPerRow, Vertex[][] latticeArray)
+ {
Point2D[] ps = new Point2D[3]; // array will be shallow-cloned in ShadedTriangle constructor
float[][] cs = new float[3][];
+ List<ShadedTriangle> list = new ArrayList<ShadedTriangle>();
for (int i = 0; i < rowNum - 1; i++)
{
for (int j = 0; j < numPerRow - 1; j++)