[jira] [Commented] (DRILL-7572) JSON structure parser

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-7572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17032170#comment-17032170 ] 

ASF GitHub Bot commented on DRILL-7572:
---------------------------------------

paul-rogers commented on pull request #1971: DRILL-7572: JSON structure parser
URL: https://github.com/apache/drill/pull/1971
 
 
   Provides a structure-driven parser for JSON. Provides an intermediate
   level beteen the Jackson JSON parser and the "shims" that write to
   Drill value vectors via the EVF.
   
   ## Description
   
   DRILL-6953, PR #1913 provides an EVF-version of the JSON reader. The original plan was to commit a first draft, with the feature disabled, then evolve from there. Review comments suggested we ensure that the first PR pass all unit tests with the feature enabled. Another comment suggested the JSON parser portion be reusable for other format or storage plugins. All good ideas.
   
   The amount of change in the original PR was becoming too large. So, we'll go ahead and split the work into smaller portions.
   
   This ticket is for the "JSON structure parser." This parser accepts the token stream from the Jackson parser and provides a framework to create a tree structure that describes the data. To keep the code simple, to simplify tests, and to make review easier, the structure parser does not directly integrate with the rest of Drill. Instead, it provides a number of listener interfaces which the next level implements. (The next level will be in another PR.)
   
   Note that, in this PR, the structure parser is an "orpjan": no other code uses it yet.
   
   ## Documentation
   
   This is not a user-visible feature. When integrated into the JSON parser, the code remove a few existing restrictions when reading JSON. Additional documentation will be provided in that future PR.
   
   ## Testing
   
   Detailed unit tests include. Reran all existing and new unit tests.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> JSON structure parser
> ---------------------
>
>                 Key: DRILL-7572
>                 URL: https://issues.apache.org/jira/browse/DRILL-7572
>             Project: Apache Drill
>          Issue Type: Improvement
>    Affects Versions: 1.18.0
>            Reporter: Paul Rogers
>            Assignee: Paul Rogers
>            Priority: Major
>             Fix For: 1.18.0
>
>
> DRILL-6953, PR #1913 provides an EVF-version of the JSON reader. The original plan was to commit a first draft, with the feature disabled, then evolve from there. Review comments suggested we ensure that the first PR pass all unit tests with the feature enabled. Another comment suggested the JSON parser portion be reusable for other format or storage plugins. All good ideas.
> The amount of change in the original PR was becoming too large. So, we'll go ahead and split the work into smaller portions.
> This ticket is for the "JSON structure parser." This parser accepts the token stream from the Jackson parser and provides a framework to create a tree structure that describes the data.  To keep the code simple, to simplify tests, and to make review easier, the structure parser does not directly integrate with the rest of Drill. Instead, it provides a number of listener interfaces which the next level implements. (The next level will be in another PR.)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)