You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/08/02 11:51:18 UTC

[GitHub] [flink] gaoyunhaii commented on a change in pull request #16633: [FLINK-21080][runtime][checkpoint] Handle UnionListState with finished operators

gaoyunhaii commented on a change in pull request #16633:
URL: https://github.com/apache/flink/pull/16633#discussion_r680905863



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointPlan.java
##########
@@ -83,4 +88,8 @@
     public List<ExecutionJobVertex> getFullyFinishedJobVertex() {
         return fullyFinishedJobVertex;
     }
+
+    public boolean isAllowsCheckpointAfterTasksFinished() {

Review comment:
       When I modified the name it occurs to me I may not need this flag, I could skip the check as long as the `finishedTasks` list is empty. Thus I removed this flag~




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org