[jira] [Commented] (HBASE-2231) Compaction events should be written to HLog

["stack (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13501364#comment-13501364 ] 

stack commented on HBASE-2231:
------------------------------

So, test passes because we are able to read from deleted file because dfsclient has block locations cached.  I suppose this makes sense it is just a little unexpected (It took me a while to figure it).

Not sure how test failed in the past.  My guess is that in the past we were strict when you went to compact that all referenced files had to be present.  That is no longer the case in that we seem to be loosey-goosey about it to handle the case where a compaction may have run before ours.  Let me look into this more.
                
> Compaction events should be written to HLog
> -------------------------------------------
>
>                 Key: HBASE-2231
>                 URL: https://issues.apache.org/jira/browse/HBASE-2231
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Blocker
>              Labels: moved_from_0_20_5
>             Fix For: 0.96.0
>
>         Attachments: 2231-testcase-0.94.txt, 2231-testcase_v2.txt, 2231v2.txt, hbase-2231-testcase.txt, hbase-2231.txt
>
>
> The sequence for a compaction should look like this:
> # Compact region to "new" files
> # Write a "Compacted Region" entry to the HLog
> # Delete "old" files
> This deals with a case where the RS has paused between step 1 and 2 and the regions have since been reassigned.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira