You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/04/08 05:10:22 UTC
[GitHub] [airflow] dstandish opened a new pull request, #22850: Fix purge dangling rows in pre-upgrade check
dstandish opened a new pull request, #22850:
URL: https://github.com/apache/airflow/pull/22850
WIP
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #22850: Fix pre-upgrade check for rows dangling w.r.t. dag_run
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22850:
URL: https://github.com/apache/airflow/pull/22850#issuecomment-1093387911
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish commented on pull request #22850: Fix pre-upgrade check for rows dangling w.r.t. dag_run
Posted by GitBox <gi...@apache.org>.
dstandish commented on PR #22850:
URL: https://github.com/apache/airflow/pull/22850#issuecomment-1093323061
> Code looks good to me: Which DBs did you test this on?
>
> (In writing these previously I found that basically all of the four DBs we support had bugs so I had to check them all.)
I am going to check all of them and will post here when that's done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish commented on pull request #22850: Fix pre-upgrade check for rows dangling w.r.t. dag_run
Posted by GitBox <gi...@apache.org>.
dstandish commented on PR #22850:
URL: https://github.com/apache/airflow/pull/22850#issuecomment-1093380426
@ashb alright, just finished testing on all 4: sqlite, mysql, postgres, mssql
i tested two ways: one from 2.1.4 and one from 2.2.4
what i do is drop all tables, and then run `airflow db upgrade --to-version 2.2.4`. then run the test file to load some data. then i run `airflow db upgrade` to bring it up to main. then i observe no errors, and inspect the tables and observe that rows are moved correctly.
i can't attach the test files to this comment but i'll see about attaching somehow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #22850: Fix pre-upgrade check for rows dangling w.r.t. dag_run
Posted by GitBox <gi...@apache.org>.
ashb commented on PR #22850:
URL: https://github.com/apache/airflow/pull/22850#issuecomment-1093311104
Code looks good to me: Which DBs did you test this on?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb merged pull request #22850: Fix pre-upgrade check for rows dangling w.r.t. dag_run
Posted by GitBox <gi...@apache.org>.
ashb merged PR #22850:
URL: https://github.com/apache/airflow/pull/22850
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org