[GitHub] [incubator-tvm] soiferj edited a comment on issue #4780: [FFI][Windows] Fix hasattr by extracting Python error type from Windows error message

[GitBox <gi...@apache.org>]

soiferj edited a comment on issue #4780: [FFI][Windows] Fix hasattr by extracting Python error type from Windows error message
URL: https://github.com/apache/incubator-tvm/pull/4780#issuecomment-579548042
 
 
   Oh interesting - your branch is throwing, while mine is just calling `LOG(FATAL)` in `reflection.cc`. Do you know why yours is throwing?
   
   Update: you're going through a different codepath (AutoTVM). Let's update the logic as below.
   
   In any case, maybe we can update the logic. I think we can condense this:
   
   ```
   if start_pos == -1:
               err_name = line[:end_pos]
               if _valid_error_name(err_name):
                   return err_name
               else:
                   return None
   err_name = line[start_pos + 1 : end_pos].strip()
   if _valid_error_name(err_name):
       return err_name
   return None
   ```
   
   into this:
   
   ```
   if start_pos == -1:
               err_name = line[:end_pos].strip()
   else:
              err_name = line[start_pos + 1 : end_pos].strip()
   if _valid_error_name(err_name):
       return err_name
   return None
   ```
   
   What do you think? Would you be able to send a PR?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services