You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/12/28 01:18:14 UTC

[GitHub] [rocketmq] yx9o opened a new issue, #5776: [code optimization] Repeated empty string check for proxy module.

yx9o opened a new issue, #5776:
URL: https://github.com/apache/rocketmq/issues/5776

   
   Hi Community,
   The latest is learning the proxy module, and found that there are some problems with repeated empty string checks.
   E.g:
   org.apache.rocketmq.proxy.grpc.v2.common.GrpcValidator#validateTopic(java.lang.String)
   org.apache.rocketmq.client.Validators#checkTopic
   ![image](https://user-images.githubusercontent.com/12792261/209742326-ef78db05-0b19-4a2b-aa85-de440df78c22.png)
   ![image](https://user-images.githubusercontent.com/12792261/209742344-cd697ad7-c433-4f43-a374-bcade530aaea.png)
   
   org.apache.rocketmq.proxy.grpc.v2.common.GrpcValidator#validateConsumerGroup(java.lang.String)
   org.apache.rocketmq.client.Validators#checkGroup
   ![image](https://user-images.githubusercontent.com/12792261/209742444-5ce503e4-aae7-4516-8926-d14b86ffd6b8.png)
   ![image](https://user-images.githubusercontent.com/12792261/209742460-9605963c-71c3-4686-b7e7-d0544d54f0e9.png)
   
   I think duplicate checks should be removed.
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] Oliverwqcwrw commented on issue #5776: [code optimization] Repeated empty string check for proxy module.

Posted by GitBox <gi...@apache.org>.

Oliverwqcwrw commented on issue #5776:
URL: https://github.com/apache/rocketmq/issues/5776#issuecomment-1370415721

   merged


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] Oliverwqcwrw closed issue #5776: [code optimization] Repeated empty string check for proxy module.

Posted by GitBox <gi...@apache.org>.

Oliverwqcwrw closed issue #5776: [code optimization] Repeated empty string check for proxy module.
URL: https://github.com/apache/rocketmq/issues/5776


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org