[jira] [Comment Edited] (HBASE-18640) Move mapreduce out of hbase-server into separate hbase-mapreduce moduel

["Appy (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-18640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16140882#comment-16140882 ] 

Appy edited comment on HBASE-18640 at 8/24/17 10:58 PM:
--------------------------------------------------------

I had split then out based solely on whether something needed hbase-server or not.

Looking at hbase-mapreduce-code (previously hbase-mapreduce-util), it has mostly Input/output formats, mappers, reducers, and some tools (RowCounter, Export, SyncTable

hadoop-mapreduce (to be renamed to something better) has: Driver, \*SnapshotInputFormat (needs snapshot stuff in server), \*HFile\{Input, Output\}Format, DefaultVisibilityExpressionResolver, and some tools (WALPlayer, ImportTsv, CopyTable, VerifyReplication).





was (Author: appy):
I had split then out based solely on whether something needed hbase-server or not.

Looking at hbase-mapreduce-code (previously hbase-mapreduce-util), it has mostly Input/output formats, mappers, reducers, and some tools (RowCounter, Export, SyncTable

hadoop-mapreduce (to be renamed to something better) has: Driver, *SnapshotInputFormat (needs snapshot stuff in server), *HFile{Input, Output}Format, DefaultVisibilityExpressionResolver, and some tools (WALPlayer, ImportTsv, CopyTable, VerifyReplication).




> Move mapreduce out of hbase-server into separate hbase-mapreduce moduel
> -----------------------------------------------------------------------
>
>                 Key: HBASE-18640
>                 URL: https://issues.apache.org/jira/browse/HBASE-18640
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Appy
>            Assignee: Appy
>         Attachments: HBASE-18640.master.001.patch, HBASE-18640.master.002.patch, HBASE-18640.master.003.patch, HBASE-18640.master.003.patch, HBASE-18640.master.004.patch, HBASE-18640.master.004.patch, HBASE-18640.master.005.patch
>
>
> (Couldn't find another dedicated jira, so creating new one).
> Uploaded patch which is moving ~60 files to the new module. Few notes:
> - The classes remaining in hbase-server are the ones which are intensively coupled with visibility labels/wal/filesystem/hfile. These can not be migrated to new module until corresponding subcomponents are untangled out of hbase-server into their own separate modules.
> - Almost all mapreduce tests uses HBaseTestingUtil, so they can't be moved to hbase-mapreduce module. Given these dependency constraints, one way would be having a separate module for tests:
> hbase-mapreduce <---- hbase-server <------- hbase-mapreduce-tests 
> Imo, this makes sense and looks fine.
> The only issue is - yetus' pre-commit. It won't run tests in hbase-mapreduce-tests module if something changed in just hbase-mapreduce. However, yetus' limitation shouldn't warrant against the idea.
> So i'd say that we should go that way, unless there are better suggestions.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)