You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by "gtchaboussie (via GitHub)" <gi...@apache.org> on 2025/01/27 13:38:32 UTC
[PR] Tomcat / Catalina upgrade [ofbiz-framework]
gtchaboussie opened a new pull request, #875:
URL: https://github.com/apache/ofbiz-framework/pull/875
Improved:
- Updates tomcat catalina and jasper version from 9.0.97 to 10.1.34
- Changes the Juel library from odyseeus to activiti implementation (up to date)
- Migrates javax to jakarta in java classes
- Migrates file upload to jakarta version
- Creation of a small utility method to handle uploads un UtilHttp
Implemented:
Documented:
Completed:
Reverted:
Fixed:
(OFBIZ-12989)
Explanation
Thanks:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Tomcat / Catalina upgrade [ofbiz-framework]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #875:
URL: https://github.com/apache/ofbiz-framework/pull/875#issuecomment-2619513599
## [](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=875) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=875&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=875&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=875&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=875&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=875&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=875)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Tomcat / Catalina upgrade [ofbiz-framework]
Posted by "JacquesLeRoux (via GitHub)" <gi...@apache.org>.
JacquesLeRoux commented on PR #875:
URL: https://github.com/apache/ofbiz-framework/pull/875#issuecomment-2618748421
Oops, moved from one Eclipse project to another and forgot the change in dependencies.gradle. Trying again...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Tomcat / Catalina upgrade [ofbiz-framework]
Posted by "JacquesLeRoux (via GitHub)" <gi...@apache.org>.
JacquesLeRoux commented on PR #875:
URL: https://github.com/apache/ofbiz-framework/pull/875#issuecomment-2616295367
We can go with warnings, but indefinitely, maybe steps by steps...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Tomcat / Catalina upgrade [ofbiz-framework]
Posted by "nmalin (via GitHub)" <gi...@apache.org>.
nmalin commented on PR #875:
URL: https://github.com/apache/ofbiz-framework/pull/875#issuecomment-2790098374
It loaded on trunk after I squash and amend the commit message : 64e5e6db5500ac87637ddf0bc43371eef561bca3
Thks all !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Tomcat / Catalina upgrade [ofbiz-framework]
Posted by "gtchaboussie (via GitHub)" <gi...@apache.org>.
gtchaboussie commented on PR #875:
URL: https://github.com/apache/ofbiz-framework/pull/875#issuecomment-2619554835
Also fixed the type warnings that i found. I'll get started on plugins !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Tomcat / Catalina upgrade [ofbiz-framework]
Posted by "nmalin (via GitHub)" <gi...@apache.org>.
nmalin closed pull request #875: Tomcat / Catalina upgrade
URL: https://github.com/apache/ofbiz-framework/pull/875
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Tomcat / Catalina upgrade [ofbiz-framework]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #875:
URL: https://github.com/apache/ofbiz-framework/pull/875#issuecomment-2615790912
## [](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=875) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=875&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=875&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=875&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=875&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=875&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=875)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Tomcat / Catalina upgrade [ofbiz-framework]
Posted by "JacquesLeRoux (via GitHub)" <gi...@apache.org>.
JacquesLeRoux commented on PR #875:
URL: https://github.com/apache/ofbiz-framework/pull/875#issuecomment-2616044645
Hi @gtchaboussie,
In framework only it builds with 34 warnings. We could see them later (seems easy, most are `warning: [rawtypes] found raw type`).
But we need the same work in plugins where we get 87 errors. I guess most related to Jakarta imports.
In the meantime I will try to run framework only as is.
Thanks for your effort
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Tomcat / Catalina upgrade [ofbiz-framework]
Posted by "gtchaboussie (via GitHub)" <gi...@apache.org>.
gtchaboussie commented on PR #875:
URL: https://github.com/apache/ofbiz-framework/pull/875#issuecomment-2616185936
Thanks @JacquesLeRoux for the feedback. I'll look into the errors you mentioned. I admit i forgiot integration tests.
I'll try to solve the raw type warnings, but i'm afrait they'll make the code a lot heavier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Tomcat / Catalina upgrade [ofbiz-framework]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #875:
URL: https://github.com/apache/ofbiz-framework/pull/875#issuecomment-2616355880
## [](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=875) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=875&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=875&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=875&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=875&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=875&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=875)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Tomcat / Catalina upgrade [ofbiz-framework]
Posted by "JacquesLeRoux (via GitHub)" <gi...@apache.org>.
JacquesLeRoux commented on PR #875:
URL: https://github.com/apache/ofbiz-framework/pull/875#issuecomment-2618637119
I still get 4
> Cannot cast object 'org.springframework.mock.web.MockHttpSession@17bf2c15' with class 'org.springframework.mock.web.MockHttpSession' to class 'jakarta.servlet.http.HttpSession'
In
testInvoicePerShipmentSetFalse
testInvoicePerShipmentSetTrue
testInvoicePerShipmentSetOrderFalse
testInvoicePerShipmentSetOrderTrue
And in
testProductTag
> No signature of method: static org.apache.ofbiz.product.product.ProductEvents.addProductTags() is applicable for argument types: (o.s.m.w.MockHttpServletRequest, o.s.m.w.MockHttpServletResponse) values: [org.springframework.mock.web.MockHttpServletRequest@3aa8ac19, org.springframework.mock.web.MockHttpServletResponse@28a8b3b3] Possible solutions: addProductTags(jakarta.servlet.http.HttpServletRequest, jakarta.servlet.http.HttpServletResponse)
Don't you?
I still have also the 3 failures:
In limitreached-test
> Error running the simple-method: java.lang.IllegalArgumentException: argument type mismatch (argument type mismatch), File#Method = GroupOrderTest.xml#testGroupOrderLimitReached, Element = <call-class-method>, Line 56null
In limitnotreached-test
>Error running the simple-method: java.lang.IllegalArgumentException: argument type mismatch (argument type
mismatch), File#Method = GroupOrderTest.xml#testGroupOrderLimitNotReached, Element = <call-class-method>, Line 178null
In configurableServiceOrder-test
>Error running the simple-method: java.lang.IllegalArgumentException: argument type mismatch (argument type mismatch), File#Method = ShoppingCartTests.xml#testCreateOrderConfigurableServiceProduct, Element = <call-class-method>, Line 594null
Could be that since it's on Windows it's due to it. But weird that it's the same exact number (3) than before (I can't remember what they were)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Tomcat / Catalina upgrade [ofbiz-framework]
Posted by "gtchaboussie (via GitHub)" <gi...@apache.org>.
gtchaboussie commented on PR #875:
URL: https://github.com/apache/ofbiz-framework/pull/875#issuecomment-2621141325
I created the MR for plugins https://github.com/apache/ofbiz-plugins/pull/133
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Tomcat / Catalina upgrade [ofbiz-framework]
Posted by "JacquesLeRoux (via GitHub)" <gi...@apache.org>.
JacquesLeRoux commented on PR #875:
URL: https://github.com/apache/ofbiz-framework/pull/875#issuecomment-2616177051
I did few random UI tests, sounds OK.
I got 26 errors and 3 failures in integration tests, mostly:
`Cannot cast object 'org.springframework.mock.web.MockHttpSession@17bf2c15' with class 'org.springframework.mock.web.MockHttpSession' to class 'jakarta.servlet.http.HttpSession' `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Tomcat / Catalina upgrade [ofbiz-framework]
Posted by "JacquesLeRoux (via GitHub)" <gi...@apache.org>.
JacquesLeRoux commented on PR #875:
URL: https://github.com/apache/ofbiz-framework/pull/875#issuecomment-2618772046
That was it, works for me. We need now to handle the plugins...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Tomcat / Catalina upgrade [ofbiz-framework]
Posted by "JacquesLeRoux (via GitHub)" <gi...@apache.org>.
JacquesLeRoux commented on PR #875:
URL: https://github.com/apache/ofbiz-framework/pull/875#issuecomment-2619558648
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Tomcat / Catalina upgrade [ofbiz-framework]
Posted by "gtchaboussie (via GitHub)" <gi...@apache.org>.
gtchaboussie commented on PR #875:
URL: https://github.com/apache/ofbiz-framework/pull/875#issuecomment-2618151514
I fixed the tests error, thanks for pointing it out
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org