You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@rya.apache.org by jdasch <gi...@git.apache.org> on 2017/10/10 15:35:08 UTC
[GitHub] incubator-rya pull request #241: RYA-333 Added "-P coverage" to generate cod...
GitHub user jdasch opened a pull request:
https://github.com/apache/incubator-rya/pull/241
RYA-333 Added "-P coverage" to generate code coverage reports.
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
## Description
Added -P coverage for generating a code-coverage report
removed unnecessary version override of the mycila license plugin
removed unnecessary argLine for the maven-surefire-plugin
### Tests
N/A
### Links
[Jira RYA-333](https://issues.apache.org/jira/browse/RYA-333)
### Checklist
- [ ] Code Review
- [X] Squash Commits
#### People To Review
@meiercaleb
@isper3at
@kchilton2
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jdasch/incubator-rya RYA-333
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rya/pull/241.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #241
----
commit ed444a567b04746f75bf5f903e22c2d9cc681d28
Author: jdasch <hc...@gmail.com>
Date: 2017-10-10T13:51:51Z
RYA-333 Added "-P coverage" to generate code coverage reports.
----
---
[GitHub] incubator-rya pull request #241: RYA-333 Added "-P coverage" to generate cod...
Posted by jdasch <gi...@git.apache.org>.
Github user jdasch commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/241#discussion_r143771929
--- Diff: pom.xml ---
@@ -151,6 +151,54 @@ under the License.
<skip.rya.it>false</skip.rya.it>
</properties>
</profile>
+
+ <!-- Enable this profile to generate a Code Coverage report with jacoco "mvn ... -P coverage" -->
+ <profile>
+ <id>coverage</id>
--- End diff --
I view code coverage as value added, especially since we are not enforcing a minimum coverage policy right now. There is a minor cost associated with running it and it is conceivable that you might not want to run it as part of the release build.
---
[GitHub] incubator-rya issue #241: RYA-333 Added "-P coverage" to generate code cover...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/incubator-rya/pull/241
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/521/<h2>Failed Tests: <span class='status-failure'>1</span></h2><h3><a name='incubator-rya-master-with-optionals-pull-requests/org.apache.rya:rya.sail' /><a href='https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/521/org.apache.rya$rya.sail/testReport'>incubator-rya-master-with-optionals-pull-requests/org.apache.rya:rya.sail</a>: <span class='status-failure'>1</span></h3><ul><li><a href='https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/521/org.apache.rya$rya.sail/testReport/org.apache.rya/RdfCloudTripleStoreTest/testForeignSelectOnlyQuery/'><strong>org.apache.rya.RdfCloudTripleStoreTest.testForeignSelectOnlyQuery</strong></a></li></ul>
---
[GitHub] incubator-rya issue #241: RYA-333 Added "-P coverage" to generate code cover...
Posted by jdasch <gi...@git.apache.org>.
Github user jdasch commented on the issue:
https://github.com/apache/incubator-rya/pull/241
asfbot build
---
[GitHub] incubator-rya issue #241: RYA-333 Added "-P coverage" to generate code cover...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/incubator-rya/pull/241
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/522/<h2>Failed Tests: <span class='status-failure'>1</span></h2><h3><a name='incubator-rya-master-with-optionals-pull-requests/org.apache.rya:rya.sail' /><a href='https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/522/org.apache.rya$rya.sail/testReport'>incubator-rya-master-with-optionals-pull-requests/org.apache.rya:rya.sail</a>: <span class='status-failure'>1</span></h3><ul><li><a href='https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/522/org.apache.rya$rya.sail/testReport/org.apache.rya/RdfCloudTripleStoreTest/testForeignSelectOnlyQuery/'><strong>org.apache.rya.RdfCloudTripleStoreTest.testForeignSelectOnlyQuery</strong></a></li></ul>
---
[GitHub] incubator-rya pull request #241: RYA-333 Added "-P coverage" to generate cod...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-rya/pull/241
---
[GitHub] incubator-rya issue #241: RYA-333 Added "-P coverage" to generate code cover...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/incubator-rya/pull/241
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/528/
---
[GitHub] incubator-rya issue #241: RYA-333 Added "-P coverage" to generate code cover...
Posted by amihalik <gi...@git.apache.org>.
Github user amihalik commented on the issue:
https://github.com/apache/incubator-rya/pull/241
I tried creating a build on b.a.o with the coverage profile enabled and "record jacoco report" plug-in enabled.
You can check on it's progress here: https://builds.apache.org/job/incubator-rya-master-with-optionals-with-coverage/
I'll roll these changes into the master builds once this PR is pulled in.
---
[GitHub] incubator-rya pull request #241: RYA-333 Added "-P coverage" to generate cod...
Posted by amihalik <gi...@git.apache.org>.
Github user amihalik commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/241#discussion_r143768364
--- Diff: pom.xml ---
@@ -151,6 +151,54 @@ under the License.
<skip.rya.it>false</skip.rya.it>
</properties>
</profile>
+
+ <!-- Enable this profile to generate a Code Coverage report with jacoco "mvn ... -P coverage" -->
+ <profile>
+ <id>coverage</id>
--- End diff --
Why have a profile? Why not just run it as default as part of the build?
---