You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by je...@apache.org on 2002/02/03 18:18:19 UTC

cvs commit: httpd-2.0/modules/proxy proxy_ftp.c

jerenkrantz    02/02/03 09:18:19

  Modified:    modules/proxy proxy_ftp.c
  Log:
  Make sure we include time.h if it is there.  (Other mojo may be needed for
  other platforms.)
  
  Revision  Changes    Path
  1.107     +3 -0      httpd-2.0/modules/proxy/proxy_ftp.c
  
  Index: proxy_ftp.c
  ===================================================================
  RCS file: /home/cvs/httpd-2.0/modules/proxy/proxy_ftp.c,v
  retrieving revision 1.106
  retrieving revision 1.107
  diff -u -r1.106 -r1.107
  --- proxy_ftp.c	1 Feb 2002 22:16:30 -0000	1.106
  +++ proxy_ftp.c	3 Feb 2002 17:18:18 -0000	1.107
  @@ -59,6 +59,9 @@
   /* FTP routines for Apache proxy */
   
   #include "mod_proxy.h"
  +#if APR_HAVE_TIME_H
  +#include <time.h>
  +#endif
   
   #define AUTODETECT_PWD
   /* Automatic timestamping (Last-Modified header) based on MDTM is used if:
  
  
  

Re: cvs commit: httpd-2.0/modules/proxy proxy_ftp.c

Posted by Justin Erenkrantz <je...@ebuilt.com>.
On Sun, Feb 03, 2002 at 04:11:38PM -0800, Greg Stein wrote:
> On Sun, Feb 03, 2002 at 05:18:19PM -0000, jerenkrantz@apache.org wrote:
> > jerenkrantz    02/02/03 09:18:19
> > 
> >   Modified:    modules/proxy proxy_ftp.c
> >   Log:
> >   Make sure we include time.h if it is there.  (Other mojo may be needed for
> >   other platforms.)
> 
> Should that code even be using time.h? If it isn't there, then what happens?
> Isn't that what APR is for?

I wish, but Martin added a bunch of code that calls the non-portable
time code directly.  I don't have the time to figure out what he was
trying to do and I just wanted a buildable tree.  -- justin


Re: cvs commit: httpd-2.0/modules/proxy proxy_ftp.c

Posted by Greg Stein <gs...@lyra.org>.
On Sun, Feb 03, 2002 at 05:18:19PM -0000, jerenkrantz@apache.org wrote:
> jerenkrantz    02/02/03 09:18:19
> 
>   Modified:    modules/proxy proxy_ftp.c
>   Log:
>   Make sure we include time.h if it is there.  (Other mojo may be needed for
>   other platforms.)

Should that code even be using time.h? If it isn't there, then what happens?
Isn't that what APR is for?

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/