You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Hari Shreedharan <hs...@cloudera.com> on 2012/11/19 08:50:47 UTC
Review Request: FLUME-1726. SpoolingFileLineReader must close the reader
before renaming.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8124/
-----------------------------------------------------------
Review request for Flume.
Description
-------
Moved the reader.close call before the rename calls.
This addresses bug FLUME-1726.
https://issues.apache.org/jira/browse/FLUME-1726
Diffs
-----
flume-ng-core/src/main/java/org/apache/flume/client/avro/SpoolingFileLineReader.java b37b730
Diff: https://reviews.apache.org/r/8124/diff/
Testing
-------
Thanks,
Hari Shreedharan
Re: Review Request: FLUME-1726. SpoolingFileLineReader must close the reader
before renaming.
Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8124/#review13569
-----------------------------------------------------------
Ship it!
Ship It!
- Brock Noland
On Nov. 19, 2012, 7:50 a.m., Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8124/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2012, 7:50 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Moved the reader.close call before the rename calls.
>
>
> This addresses bug FLUME-1726.
> https://issues.apache.org/jira/browse/FLUME-1726
>
>
> Diffs
> -----
>
> flume-ng-core/src/main/java/org/apache/flume/client/avro/SpoolingFileLineReader.java b37b730
>
> Diff: https://reviews.apache.org/r/8124/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hari Shreedharan
>
>