[GitHub] [ozone] xiaoyuyao commented on a change in pull request #2011: HDDS-4691. [FSO]Authorizer: OM can do recursive ACL check for subpaths

[GitBox <gi...@apache.org>]

xiaoyuyao commented on a change in pull request #2011:
URL: https://github.com/apache/ozone/pull/2011#discussion_r590512178



##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyRenameRequestV1.java
##########
@@ -108,6 +115,36 @@ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager,
       checkKeyAcls(ozoneManager, volumeName, bucketName, toKeyName,
               IAccessAuthorizer.ACLType.CREATE, OzoneObj.ResourceType.KEY);
 
+      if (isNativeAuthorizerEnabled) {

Review comment:
       Given the new recursive check flat added, can we move this recursion inside the authorizer and only provide the API for the authorizer to get the key list like what we provide for the ranger authorizer?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org