You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/04/03 14:31:52 UTC

[GitHub] [skywalking] juzhiyuan opened a new pull request #6678: doc: added contributor over time

juzhiyuan opened a new pull request #6678:
URL: https://github.com/apache/skywalking/pull/6678


   Hi, due to I have not seen any section that matches this PR, then I remove all of them 🤔 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on pull request #6678: doc: added contributor over time

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #6678:
URL: https://github.com/apache/skywalking/pull/6678#issuecomment-812947175


   Do you mean api7 host service? Be careful anout it.
   ASF TLP relies on commercial vendor website, which could be a concern by PMC, even ASF at policy level.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on pull request #6678: doc: added contributor over time

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #6678:
URL: https://github.com/apache/skywalking/pull/6678#issuecomment-812985653


   > 😂 ok, got it. But making a chart that contains multiple repos' trends is a little hard in this style. Let us reconsider.
   
   I just recommend to use one line in the graph. I am feeling you are thinking one line per repo


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] juzhiyuan commented on pull request #6678: doc: added contributor over time

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #6678:
URL: https://github.com/apache/skywalking/pull/6678#issuecomment-812943935


   ok, let me do it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on pull request #6678: doc: added contributor over time

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #6678:
URL: https://github.com/apache/skywalking/pull/6678#issuecomment-812944413


   When you do this, please make sure it is either attched on every project, or aggregating all projects data into one graph, considering SkyWalking has many subprojects.
   Also, we need this to rebuild every time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] juzhiyuan edited a comment on pull request #6678: doc: added contributor over time

Posted by GitBox <gi...@apache.org>.
juzhiyuan edited a comment on pull request #6678:
URL: https://github.com/apache/skywalking/pull/6678#issuecomment-812947514


   Yes, this graph is generated by API7, but for now, I will generate every graph by that service, without any commercial information actually 🤔 
   
   > And we will support one link target to a dynamic graph, so we don't have to update that graph every time.
   
   This feature is still in progress :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on pull request #6678: doc: added contributor over time

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #6678:
URL: https://github.com/apache/skywalking/pull/6678#issuecomment-812875715


   The team page will be updated every day and once new PR merged in the website repo, like we did for the document.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on pull request #6678: doc: added contributor over time

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #6678:
URL: https://github.com/apache/skywalking/pull/6678#issuecomment-812948245


   > Yes, this graph is generated by API7, but for now, I will generate every graph by that service, without any commercial information actually 🤔
   > 
   > > And we will support one link target to a dynamic graph, so we don't have to update that graph every time.
   > 
   > This feature is still in progress :)
   
   Yes, but you will add it into the website pipeline or accessing api7 service address every time when user accesses this team page.
   Either way, you need the PMC approval(vote) to accept this. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] juzhiyuan commented on pull request #6678: doc: added contributor over time

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #6678:
URL: https://github.com/apache/skywalking/pull/6678#issuecomment-812957377


   😂 ok, got it. But making a chart that contains multiple repos' trends is a little hard in this style. Let us reconsider.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on pull request #6678: doc: added contributor over time

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #6678:
URL: https://github.com/apache/skywalking/pull/6678#issuecomment-812951066


   > ![image](https://user-images.githubusercontent.com/2106987/113494850-0e37e100-951f-11eb-876e-2abb8e020606.png)
   > 
   > Yes, when I try to add all projects, I find that it has too many projects 😂 Could we attach this graph for every project? (on the README file instead of website).
   
   We removed this kind of graph including star trend from the readme. SkyWalking is focusing on GitHub for development, website for users. @Jtrust is leading all things, we have no plan to add them back.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] juzhiyuan commented on pull request #6678: doc: added contributor over time

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #6678:
URL: https://github.com/apache/skywalking/pull/6678#issuecomment-812947514


   Yes, this graph is generated by API7, and for now, I will generate every graph by that service, without any commercial information actually 🤔 
   
   > And we will support one link target to a dynamic graph, so we don't have to update that graph every time.
   
   This feature is still in progress :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] juzhiyuan commented on pull request #6678: doc: added contributor over time

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #6678:
URL: https://github.com/apache/skywalking/pull/6678#issuecomment-812945825


   > When you do this, please make sure it is either attched on every project, or aggregating all projects data into one graph, considering SkyWalking has many subprojects.
   > Also, we need this to rebuild every time.
   
   Good catch! Let me generate a graph contains all subprojects :)
   
   And we will support one link target to a dynamic graph, so we don't have to update that graph every time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] juzhiyuan closed pull request #6678: doc: added contributor over time

Posted by GitBox <gi...@apache.org>.
juzhiyuan closed pull request #6678:
URL: https://github.com/apache/skywalking/pull/6678


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on pull request #6678: doc: added contributor over time

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #6678:
URL: https://github.com/apache/skywalking/pull/6678#issuecomment-812875471


   I think you should add this to the website, if you like the trend graph from time to time.
   https://skywalking.apache.org/team/


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] juzhiyuan commented on pull request #6678: doc: added contributor over time

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #6678:
URL: https://github.com/apache/skywalking/pull/6678#issuecomment-812947147


   It's not clear for repos that don't have too many contributors when combining all of the projects.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on pull request #6678: doc: added contributor over time

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #6678:
URL: https://github.com/apache/skywalking/pull/6678#issuecomment-812948348


   Also, I am guessing you mean the 2nd way, then your service speed to global people matters.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] juzhiyuan commented on pull request #6678: doc: added contributor over time

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #6678:
URL: https://github.com/apache/skywalking/pull/6678#issuecomment-812946952


   ![image](https://user-images.githubusercontent.com/2106987/113494850-0e37e100-951f-11eb-876e-2abb8e020606.png)
   
   Yes, when I try to add all projects, I find that it has too many projects 😂 Could we attach this graph for every project? (on the README file instead of website).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on pull request #6678: doc: added contributor over time

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #6678:
URL: https://github.com/apache/skywalking/pull/6678#issuecomment-812951479


   > It's not clear for repos that don't have too many contributors when combining all of the projects.
   
   I prefer to add this to the whole ecosystem, rather than a repo. For SkyWalking, contributions to any repo are same, and we appreciated them in same.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org