You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Benedikt Ritter (Created) (JIRA)" <ji...@apache.org> on 2012/01/20 19:13:39 UTC

[jira] [Created] (SANDBOX-362) Create basic unit tests for all classes

Create basic unit tests for all classes
---------------------------------------

                 Key: SANDBOX-362
                 URL: https://issues.apache.org/jira/browse/SANDBOX-362
             Project: Commons Sandbox
          Issue Type: Test
          Components: BeanUtils2
    Affects Versions: Nightly Builds
            Reporter: Benedikt Ritter


Back up all existing implementations with unit tests:

* Argument
* Assertions
* BeanUtils
* DefaultBeanAccessor
* DefaultClassAccessor
* MethodRegistry
* TypeUtils

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (SANDBOX-362) Create basic unit tests for all classes

Posted by "Benedikt Ritter (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SANDBOX-362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benedikt Ritter updated SANDBOX-362:
------------------------------------

    Attachment: SANDBOX-362-TypeUtilsTest.txt

Hi,

I have created a patch that adds a unit test for type utils. The test consists of 244 test methods. To be honest, it has been a lot of copy and paste work. But I think that TypeUtils is one of the central classes, so one test more or less doesn't hurt (or does it?). I wanted to test at least every possible combination of primtives and wrapper types. If you think, that the test is to huge, just let me know!

@Simo: if you apply the patch, think very carefully if you want to change TypeUtils afterwards. It will beak a bazillion tests ;-)
                
> Create basic unit tests for all classes
> ---------------------------------------
>
>                 Key: SANDBOX-362
>                 URL: https://issues.apache.org/jira/browse/SANDBOX-362
>             Project: Commons Sandbox
>          Issue Type: Test
>          Components: BeanUtils2
>    Affects Versions: Nightly Builds
>            Reporter: Benedikt Ritter
>         Attachments: ArgumentTest.zip, SANDBOX-362-RefactoringOfArgumentTest.txt, SANDBOX-362-TypeUtilsTest.txt
>
>
> Back up all existing implementations with unit tests:
> * Argument
> * Assertions
> * BeanUtils
> * DefaultBeanAccessor
> * DefaultClassAccessor
> * MethodRegistry
> * TypeUtils

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (SANDBOX-362) Create basic unit tests for all classes

Posted by "Simone Tripodi (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SANDBOX-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13192501#comment-13192501 ] 

Simone Tripodi commented on SANDBOX-362:
----------------------------------------

hey, I usually run tests before committing!
                
> Create basic unit tests for all classes
> ---------------------------------------
>
>                 Key: SANDBOX-362
>                 URL: https://issues.apache.org/jira/browse/SANDBOX-362
>             Project: Commons Sandbox
>          Issue Type: Test
>          Components: BeanUtils2
>    Affects Versions: Nightly Builds
>            Reporter: Benedikt Ritter
>         Attachments: ArgumentTest.zip, SANDBOX-362-RefactoringOfArgumentTest.txt, SANDBOX-362-TypeUtilsTest.txt
>
>
> Back up all existing implementations with unit tests:
> * Argument
> * Assertions
> * BeanUtils
> * DefaultBeanAccessor
> * DefaultClassAccessor
> * MethodRegistry
> * TypeUtils

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Issue Comment Edited] (SANDBOX-362) Create basic unit tests for all classes

Posted by "Benedikt Ritter (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SANDBOX-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13191495#comment-13191495 ] 

Benedikt Ritter edited comment on SANDBOX-362 at 1/23/12 9:43 PM:
------------------------------------------------------------------

Based on a discussion we had on the mailing list about best practices for unit tests, I refactored ArgumentTest and added test methods for getParamaters(Argument<?>... args).

Here is a summary of what I changed:
* separated long methods into very small methods: each primitive type has it's own test methods
* defined fields for every primitive type, to make sure that assertions do not accedential fail because wrong values get compared
* created separate test methods instead of wrapping failure cases inside try/catch-blocks
* Added tests methods that test against TestBean.class

Please let me know, what you think about the changes!
                
      was (Author: britter):
    Based on a discussion we had on the mailing list about best practices for unit tests, I refactored ArgumentTest and added test methods for getParamaters(Argument<?>... args).

Here is a summary of what I changed:
* separated long methods into very small methods: each primitive type has it's own test methods
* defined fields for every primitive type, to make sure that assertions do not accedential fail because wrong values get compared
* Added tests methods that test against TestBean.class

Please let me know, what you think about the changes!
                  
> Create basic unit tests for all classes
> ---------------------------------------
>
>                 Key: SANDBOX-362
>                 URL: https://issues.apache.org/jira/browse/SANDBOX-362
>             Project: Commons Sandbox
>          Issue Type: Test
>          Components: BeanUtils2
>    Affects Versions: Nightly Builds
>            Reporter: Benedikt Ritter
>         Attachments: ArgumentTest.zip, SANDBOX-362-RefactoringOfArgumentTest.txt
>
>
> Back up all existing implementations with unit tests:
> * Argument
> * Assertions
> * BeanUtils
> * DefaultBeanAccessor
> * DefaultClassAccessor
> * MethodRegistry
> * TypeUtils

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (SANDBOX-362) Create basic unit tests for all classes

Posted by "Simone Tripodi (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SANDBOX-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13194591#comment-13194591 ] 

Simone Tripodi commented on SANDBOX-362:
----------------------------------------

very good patch Benedict, it has been successfully applied, see [r1236622|https://svn.apache.org/viewvc?view=revision&revision=1236622]

thanks!
                
> Create basic unit tests for all classes
> ---------------------------------------
>
>                 Key: SANDBOX-362
>                 URL: https://issues.apache.org/jira/browse/SANDBOX-362
>             Project: Commons Sandbox
>          Issue Type: Test
>          Components: BeanUtils2
>    Affects Versions: Nightly Builds
>            Reporter: Benedikt Ritter
>         Attachments: ArgumentTest.zip, SANDBOX-362-RefactoringOfArgumentTest.txt, SANDBOX-362-RefactoringOfAssertionsTest.txt, SANDBOX-362-TypeUtilsTest.txt
>
>
> Back up all existing implementations with unit tests:
> * Argument
> * Assertions
> * BeanUtils
> * DefaultBeanAccessor
> * DefaultClassAccessor
> * MethodRegistry
> * TypeUtils

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (SANDBOX-362) Create basic unit tests for all classes

Posted by "Simone Tripodi (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SANDBOX-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13194841#comment-13194841 ] 

Simone Tripodi commented on SANDBOX-362:
----------------------------------------

Hi Benedikt,

I think that redundancies are not evil but in that case they are not very helpful because they don't change the test coverage result.

BeanUtils APIs tests purpose should be:

 * make sure null Class is not accepted
 * make sure null Object is not accepted
 * accepts a Class
 * accepts a Bean

nothing more, unless we decide to add more public methods.
                
> Create basic unit tests for all classes
> ---------------------------------------
>
>                 Key: SANDBOX-362
>                 URL: https://issues.apache.org/jira/browse/SANDBOX-362
>             Project: Commons Sandbox
>          Issue Type: Test
>          Components: BeanUtils2
>    Affects Versions: Nightly Builds
>            Reporter: Benedikt Ritter
>         Attachments: ArgumentTest.zip, SANDBOX-362-BeanUtilsTest.txt, SANDBOX-362-RefactoringOfArgumentTest.txt, SANDBOX-362-RefactoringOfAssertionsTest.txt, SANDBOX-362-TypeUtilsTest.txt
>
>
> Back up all existing implementations with unit tests:
> * Argument
> * Assertions
> * BeanUtils
> * DefaultBeanAccessor
> * DefaultClassAccessor
> * MethodRegistry
> * TypeUtils

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (SANDBOX-362) Create basic unit tests for all classes

Posted by "Benedikt Ritter (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SANDBOX-362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benedikt Ritter updated SANDBOX-362:
------------------------------------

    Attachment: SANDBOX-362-RefactoringOfAssertionsTest.txt

As announced on the mailing list, I refactored AssertionsTest ;-) Summary:

* created smaller methods for different failure cases
* added an ExpectedException test rule to validate correct errorTemplate and errorArgs processing

moving on to the next class :-)
                
> Create basic unit tests for all classes
> ---------------------------------------
>
>                 Key: SANDBOX-362
>                 URL: https://issues.apache.org/jira/browse/SANDBOX-362
>             Project: Commons Sandbox
>          Issue Type: Test
>          Components: BeanUtils2
>    Affects Versions: Nightly Builds
>            Reporter: Benedikt Ritter
>         Attachments: ArgumentTest.zip, SANDBOX-362-RefactoringOfArgumentTest.txt, SANDBOX-362-RefactoringOfAssertionsTest.txt, SANDBOX-362-TypeUtilsTest.txt
>
>
> Back up all existing implementations with unit tests:
> * Argument
> * Assertions
> * BeanUtils
> * DefaultBeanAccessor
> * DefaultClassAccessor
> * MethodRegistry
> * TypeUtils

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (SANDBOX-362) Create basic unit tests for all classes

Posted by "Simone Tripodi (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SANDBOX-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13191513#comment-13191513 ] 

Simone Tripodi commented on SANDBOX-362:
----------------------------------------

Terrific :) I have already applied your patch, see [r1235012|https://svn.apache.org/viewvc?view=revision&revision=1235012], thanks for contributing!!!
                
> Create basic unit tests for all classes
> ---------------------------------------
>
>                 Key: SANDBOX-362
>                 URL: https://issues.apache.org/jira/browse/SANDBOX-362
>             Project: Commons Sandbox
>          Issue Type: Test
>          Components: BeanUtils2
>    Affects Versions: Nightly Builds
>            Reporter: Benedikt Ritter
>         Attachments: ArgumentTest.zip, SANDBOX-362-RefactoringOfArgumentTest.txt
>
>
> Back up all existing implementations with unit tests:
> * Argument
> * Assertions
> * BeanUtils
> * DefaultBeanAccessor
> * DefaultClassAccessor
> * MethodRegistry
> * TypeUtils

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (SANDBOX-362) Create basic unit tests for all classes

Posted by "Benedikt Ritter (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SANDBOX-362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benedikt Ritter updated SANDBOX-362:
------------------------------------

    Attachment: ArgumentTest.zip

I've attached a jUnit Test for Argument. Please let me know, what you think about it. I've not written test methods for getType() and getValue(), since those are backed up by the other methods.
                
> Create basic unit tests for all classes
> ---------------------------------------
>
>                 Key: SANDBOX-362
>                 URL: https://issues.apache.org/jira/browse/SANDBOX-362
>             Project: Commons Sandbox
>          Issue Type: Test
>          Components: BeanUtils2
>    Affects Versions: Nightly Builds
>            Reporter: Benedikt Ritter
>         Attachments: ArgumentTest.zip
>
>
> Back up all existing implementations with unit tests:
> * Argument
> * Assertions
> * BeanUtils
> * DefaultBeanAccessor
> * DefaultClassAccessor
> * MethodRegistry
> * TypeUtils

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (SANDBOX-362) Create basic unit tests for all classes

Posted by "Simone Tripodi (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SANDBOX-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195446#comment-13195446 ] 

Simone Tripodi commented on SANDBOX-362:
----------------------------------------

Hi Benedikt,

great. Since classes will increase in therms of number, it would be better for, future contributions , to open subtasks and attach there patches, otherwise it is confusing to keept track which patches have been applied and which not.

Thanks for your contributions!
                
> Create basic unit tests for all classes
> ---------------------------------------
>
>                 Key: SANDBOX-362
>                 URL: https://issues.apache.org/jira/browse/SANDBOX-362
>             Project: Commons Sandbox
>          Issue Type: Test
>          Components: BeanUtils2
>    Affects Versions: Nightly Builds
>            Reporter: Benedikt Ritter
>            Assignee: Simone Tripodi
>         Attachments: ArgumentTest.zip, SANDBOX-362-BeanUtilsTest.txt, SANDBOX-362-ConstructorTestCase.txt, SANDBOX-362-RefactoringOfArgumentTest.txt, SANDBOX-362-RefactoringOfAssertionsTest.txt, SANDBOX-362-TypeUtilsTest.txt
>
>
> Back up all existing implementations with unit tests:
> * Argument
> * Assertions
> * BeanUtils
> * DefaultBeanAccessor
> * DefaultClassAccessor
> * MethodRegistry
> * TypeUtils

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (SANDBOX-362) Create basic unit tests for all classes

Posted by "Simone Tripodi (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SANDBOX-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13192510#comment-13192510 ] 

Simone Tripodi commented on SANDBOX-362:
----------------------------------------

thanks again for your contribution!!! patch has been successfully applied, see [r1235494|https://svn.apache.org/viewvc?view=revision&revision=1235494]

looking forward to the next!
                
> Create basic unit tests for all classes
> ---------------------------------------
>
>                 Key: SANDBOX-362
>                 URL: https://issues.apache.org/jira/browse/SANDBOX-362
>             Project: Commons Sandbox
>          Issue Type: Test
>          Components: BeanUtils2
>    Affects Versions: Nightly Builds
>            Reporter: Benedikt Ritter
>         Attachments: ArgumentTest.zip, SANDBOX-362-RefactoringOfArgumentTest.txt, SANDBOX-362-TypeUtilsTest.txt
>
>
> Back up all existing implementations with unit tests:
> * Argument
> * Assertions
> * BeanUtils
> * DefaultBeanAccessor
> * DefaultClassAccessor
> * MethodRegistry
> * TypeUtils

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (SANDBOX-362) Create basic unit tests for all classes

Posted by "Benedikt Ritter (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SANDBOX-362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benedikt Ritter updated SANDBOX-362:
------------------------------------

    Attachment: SANDBOX-362-RefactoringOfArgumentTest.txt

Based on a discussion we had on the mailing list about best practices for unit tests, I refactored ArgumentTest and added test methods for getParamaters(Argument<?>... args).

Here is a summary of what I changed:
* separated long methods into very small methods: each primitive type has it's own test methods
* defined fields for every primitive type, to make sure that assertions do not accedential fail because wrong values get compared
* Added tests methods that test against TestBean.class

Please let me know, what you think about the changes!
                
> Create basic unit tests for all classes
> ---------------------------------------
>
>                 Key: SANDBOX-362
>                 URL: https://issues.apache.org/jira/browse/SANDBOX-362
>             Project: Commons Sandbox
>          Issue Type: Test
>          Components: BeanUtils2
>    Affects Versions: Nightly Builds
>            Reporter: Benedikt Ritter
>         Attachments: ArgumentTest.zip, SANDBOX-362-RefactoringOfArgumentTest.txt
>
>
> Back up all existing implementations with unit tests:
> * Argument
> * Assertions
> * BeanUtils
> * DefaultBeanAccessor
> * DefaultClassAccessor
> * MethodRegistry
> * TypeUtils

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (SANDBOX-362) Create basic unit tests for all classes

Posted by "Benedikt Ritter (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SANDBOX-362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benedikt Ritter updated SANDBOX-362:
------------------------------------

    Attachment: SANDBOX-362-ConstructorTestCase.txt

Hi again,

I have attached a patch for ConstructorTestCase. Summary:

* moved expected failure cases to own test methods
* added test methods for null arguments
* added ExceptedException test rule to verify that correct exceptions are thrown

I still don't like, that some methods test more than one constructor. Maybe we should create separate methods for those.

I also changed an exception message in DefaultClassAccessor from 
"No such accessible constructor on object:"
to
"No such accessible constructor on class:"
because I think that this is more convenient.

Regards
Benedikt

                
> Create basic unit tests for all classes
> ---------------------------------------
>
>                 Key: SANDBOX-362
>                 URL: https://issues.apache.org/jira/browse/SANDBOX-362
>             Project: Commons Sandbox
>          Issue Type: Test
>          Components: BeanUtils2
>    Affects Versions: Nightly Builds
>            Reporter: Benedikt Ritter
>         Attachments: ArgumentTest.zip, SANDBOX-362-BeanUtilsTest.txt, SANDBOX-362-ConstructorTestCase.txt, SANDBOX-362-RefactoringOfArgumentTest.txt, SANDBOX-362-RefactoringOfAssertionsTest.txt, SANDBOX-362-TypeUtilsTest.txt
>
>
> Back up all existing implementations with unit tests:
> * Argument
> * Assertions
> * BeanUtils
> * DefaultBeanAccessor
> * DefaultClassAccessor
> * MethodRegistry
> * TypeUtils

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (SANDBOX-362) Create basic unit tests for all classes

Posted by "Benedikt Ritter (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SANDBOX-362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benedikt Ritter updated SANDBOX-362:
------------------------------------

    Attachment: SANDBOX-362-BeanUtilsTest.txt

I have created a very basic Test for BeanUtils. All it does is testing if the _on_-methods return a result != null for every primitive and every wrapper type. Any ideas what else we could test regarding BeanUtils class?

The test is a bit redundant, because the _on_-methods get tested in ConstructorTestCase and StaticMethodTestCase as well. But since BeanUtils serves as the entry point for the hole library, I thought we should be absolutely sure that everything is working correct there.
                
> Create basic unit tests for all classes
> ---------------------------------------
>
>                 Key: SANDBOX-362
>                 URL: https://issues.apache.org/jira/browse/SANDBOX-362
>             Project: Commons Sandbox
>          Issue Type: Test
>          Components: BeanUtils2
>    Affects Versions: Nightly Builds
>            Reporter: Benedikt Ritter
>         Attachments: ArgumentTest.zip, SANDBOX-362-BeanUtilsTest.txt, SANDBOX-362-RefactoringOfArgumentTest.txt, SANDBOX-362-RefactoringOfAssertionsTest.txt, SANDBOX-362-TypeUtilsTest.txt
>
>
> Back up all existing implementations with unit tests:
> * Argument
> * Assertions
> * BeanUtils
> * DefaultBeanAccessor
> * DefaultClassAccessor
> * MethodRegistry
> * TypeUtils

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (SANDBOX-362) Create basic unit tests for all classes

Posted by "Simone Tripodi (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SANDBOX-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190075#comment-13190075 ] 

Simone Tripodi commented on SANDBOX-362:
----------------------------------------

Your contribution has been applied Benedikt, thanks a lot! see [r1234115|https://svn.apache.org/viewvc?view=revision&revision=1234115]

I have to ask you anyway the favor of, for future contributions, read and follow the [On Contributing Patches|http://commons.apache.org/patches.html] guide, widely adopted in commons.

For that case I applied the contribution since it is an addition class, but when modifying the original source code, the patch fits better because shows what has been modified.

Dankeshön!!!
                
> Create basic unit tests for all classes
> ---------------------------------------
>
>                 Key: SANDBOX-362
>                 URL: https://issues.apache.org/jira/browse/SANDBOX-362
>             Project: Commons Sandbox
>          Issue Type: Test
>          Components: BeanUtils2
>    Affects Versions: Nightly Builds
>            Reporter: Benedikt Ritter
>         Attachments: ArgumentTest.zip
>
>
> Back up all existing implementations with unit tests:
> * Argument
> * Assertions
> * BeanUtils
> * DefaultBeanAccessor
> * DefaultClassAccessor
> * MethodRegistry
> * TypeUtils

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Commented] (SANDBOX-362) Create basic unit tests for all classes

Posted by "Benedikt Ritter (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SANDBOX-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13192486#comment-13192486 ] 

Benedikt Ritter commented on SANDBOX-362:
-----------------------------------------

Forgot to mention: I also added some not null checks to TypeUtil.
                
> Create basic unit tests for all classes
> ---------------------------------------
>
>                 Key: SANDBOX-362
>                 URL: https://issues.apache.org/jira/browse/SANDBOX-362
>             Project: Commons Sandbox
>          Issue Type: Test
>          Components: BeanUtils2
>    Affects Versions: Nightly Builds
>            Reporter: Benedikt Ritter
>         Attachments: ArgumentTest.zip, SANDBOX-362-RefactoringOfArgumentTest.txt, SANDBOX-362-TypeUtilsTest.txt
>
>
> Back up all existing implementations with unit tests:
> * Argument
> * Assertions
> * BeanUtils
> * DefaultBeanAccessor
> * DefaultClassAccessor
> * MethodRegistry
> * TypeUtils

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira