You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by rishitesh <gi...@git.apache.org> on 2016/03/06 12:15:34 UTC
[GitHub] spark pull request: Spark 13705
GitHub user rishitesh opened a pull request:
https://github.com/apache/spark/pull/11545
Spark 13705
## What changes were proposed in this pull request?
The reference to StatefulNetworkWordCount.scala from updateStatesByKey documentation should be removed, till there is a example for updateStatesByKey.
## How was this patch tested?
Have tested the new documentation with jekyll build.
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rishitesh/spark SPARK-13705
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/11545.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #11545
----
commit 65a34c71e59ed66f8d667b89ef6f8ff56dcb5b09
Author: rmishra <rm...@pivotal.io>
Date: 2016-03-06T10:55:21Z
Doc Issue : Apache Spark Streaming guide elaborates UpdateStateByKey Operation and goes onto give an example. However for complete code sample it referes to {{site.SPARK_GITHUB_URL}}/blob/master/examples/src/main/scala/org/apache
/spark/examples/streaming/StatefulNetworkWordCount.scala). StatefulNetworkWordCount.scala has changed to demonstrate more recent API mapWithState.
This creates confusion in the document.
Till the time more detailed explanation of mapWIthState is added the reference to StatefulNetworkWordCount.scala should be removed.
commit 40a40ed5e3540cd528d2cf7c555243c2b1e6a6d7
Author: rmishra <rm...@pivotal.io>
Date: 2016-03-06T11:05:52Z
Revert "Doc Issue : Apache Spark Streaming guide elaborates UpdateStateByKey Operation and goes onto give an example. However for complete code sample it referes to {{site.SPARK_GITHUB_URL}}/blob/master/examples/src/main/scala/org/apache"
This reverts commit 65a34c71e59ed66f8d667b89ef6f8ff56dcb5b09.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Spark-13705][Docs]UpdateStateByKey Operation ...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/11545#issuecomment-193186288
Merged to master/1.6
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Spark 13705
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11545#issuecomment-192876053
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Spark 13705 : UpdateStateByKey Operation docum...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/11545#issuecomment-192968174
@rishitesh you need to read https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark before opening a JIRA or PR. You didn't link them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Spark-13705][Docs]UpdateStateByKey Operation ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/11545
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org