You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by mn...@apache.org on 2026/02/06 11:34:20 UTC

(arrow-rs-object-store) branch main updated: Implement typos-cli (#570)

This is an automated email from the ASF dual-hosted git repository.

mneumann pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow-rs-object-store.git


The following commit(s) were added to refs/heads/main by this push:
     new fc620ab  Implement typos-cli (#570)
fc620ab is described below

commit fc620abc8ab9048063066afaf4153f44051125e1
Author: John Vandenberg <ja...@gmail.com>
AuthorDate: Fri Feb 6 19:34:14 2026 +0800

    Implement typos-cli (#570)
    
    * Implement typos-cli
    
    * Add liense header
    
    * Another typo
---
 .github/workflows/typos.yml | 42 ++++++++++++++++++++++++++++++++++++++++++
 CHANGELOG-old.md            |  8 ++++----
 _typos.toml                 | 31 +++++++++++++++++++++++++++++++
 src/azure/client.rs         |  4 ++--
 src/gcp/builder.rs          |  8 ++++----
 src/lib.rs                  |  2 +-
 6 files changed, 84 insertions(+), 11 deletions(-)

diff --git a/.github/workflows/typos.yml b/.github/workflows/typos.yml
new file mode 100644
index 0000000..58481d5
--- /dev/null
+++ b/.github/workflows/typos.yml
@@ -0,0 +1,42 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+---
+name: Typos
+
+concurrency:
+  group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{ github.workflow }}
+  cancel-in-progress: true
+
+on:
+  push:
+    branches:
+      - main
+  pull_request:
+
+jobs:
+  typos:
+    name: Check for typos
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v6
+      - name: Install typos
+        uses: taiki-e/install-action@v2
+        with:
+          tool: typos
+      - name: Run typos
+        run: typos
diff --git a/CHANGELOG-old.md b/CHANGELOG-old.md
index 5cab275..b67aa35 100644
--- a/CHANGELOG-old.md
+++ b/CHANGELOG-old.md
@@ -353,7 +353,7 @@
 - Remove all RCs after release [\#7060](https://github.com/apache/arrow-rs/pull/7060) [[object-store](https://github.com/apache/arrow-rs/labels/object-store)] ([kou](https://github.com/kou))
 - Update release schedule README.md [\#7053](https://github.com/apache/arrow-rs/pull/7053) ([alamb](https://github.com/alamb))
 - Create GitHub releases automatically on tagging [\#7042](https://github.com/apache/arrow-rs/pull/7042) ([kou](https://github.com/kou))
-- Change Log On Succesful S3 Copy / Multipart Upload to Debug [\#7033](https://github.com/apache/arrow-rs/pull/7033) [[object-store](https://github.com/apache/arrow-rs/labels/object-store)] ([diptanu](https://github.com/diptanu))
+- Change Log On Successful S3 Copy / Multipart Upload to Debug [\#7033](https://github.com/apache/arrow-rs/pull/7033) [[object-store](https://github.com/apache/arrow-rs/labels/object-store)] ([diptanu](https://github.com/diptanu))
 - Prepare for `54.1.0` release [\#7031](https://github.com/apache/arrow-rs/pull/7031) ([alamb](https://github.com/alamb))
 - Add a custom implementation `LocalFileSystem::list_with_offset`  [\#7019](https://github.com/apache/arrow-rs/pull/7019) [[object-store](https://github.com/apache/arrow-rs/labels/object-store)] ([corwinjoy](https://github.com/corwinjoy))
 - Improve docs for `AmazonS3Builder::from_env` [\#6977](https://github.com/apache/arrow-rs/pull/6977) [[object-store](https://github.com/apache/arrow-rs/labels/object-store)] ([kylebarron](https://github.com/kylebarron))
@@ -606,7 +606,7 @@
 
 - Expose path\_to\_filesystem public [\#5441](https://github.com/apache/arrow-rs/pull/5441) [[object-store](https://github.com/apache/arrow-rs/labels/object-store)] ([metesynnada](https://github.com/metesynnada))
 - Update nix requirement from 0.27.1 to 0.28.0 in /object\_store [\#5432](https://github.com/apache/arrow-rs/pull/5432) [[object-store](https://github.com/apache/arrow-rs/labels/object-store)] ([dependabot[bot]](https://github.com/apps/dependabot))
-- Add BufWriter for Adapative Put / Multipart Upload [\#5431](https://github.com/apache/arrow-rs/pull/5431) [[object-store](https://github.com/apache/arrow-rs/labels/object-store)] ([tustvold](https://github.com/tustvold))
+- Add BufWriter for Adaptive Put / Multipart Upload [\#5431](https://github.com/apache/arrow-rs/pull/5431) [[object-store](https://github.com/apache/arrow-rs/labels/object-store)] ([tustvold](https://github.com/tustvold))
 - Enable anonymous access for MicrosoftAzure [\#5425](https://github.com/apache/arrow-rs/pull/5425) [[object-store](https://github.com/apache/arrow-rs/labels/object-store)] ([andrebsguedes](https://github.com/andrebsguedes))
 - fix\(object\_store\): Include Content-MD5 header for S3 DeleteObjects [\#5415](https://github.com/apache/arrow-rs/pull/5415) [[object-store](https://github.com/apache/arrow-rs/labels/object-store)] ([paraseba](https://github.com/paraseba))
 - docds\(object\_store\): Mention HTTP/WebDAV in README [\#5409](https://github.com/apache/arrow-rs/pull/5409) [[object-store](https://github.com/apache/arrow-rs/labels/object-store)] ([Xuanwo](https://github.com/Xuanwo))
@@ -898,7 +898,7 @@
 - Skip test\_list\_root on OS X \(\#3772\) [\#4198](https://github.com/apache/arrow-rs/pull/4198) [[object-store](https://github.com/apache/arrow-rs/labels/object-store)] ([tustvold](https://github.com/tustvold))
 - Recognise R2 URLs for S3 object store \(\#4190\) [\#4194](https://github.com/apache/arrow-rs/pull/4194) [[object-store](https://github.com/apache/arrow-rs/labels/object-store)] ([tustvold](https://github.com/tustvold))
 - Fix ImdsManagedIdentityProvider \(\#4096\) [\#4193](https://github.com/apache/arrow-rs/pull/4193) [[object-store](https://github.com/apache/arrow-rs/labels/object-store)] ([tustvold](https://github.com/tustvold))
-- Deffered Object Store Config Parsing \(\#4191\)  [\#4192](https://github.com/apache/arrow-rs/pull/4192) [[object-store](https://github.com/apache/arrow-rs/labels/object-store)] ([tustvold](https://github.com/tustvold))
+- Deferred Object Store Config Parsing \(\#4191\)  [\#4192](https://github.com/apache/arrow-rs/pull/4192) [[object-store](https://github.com/apache/arrow-rs/labels/object-store)] ([tustvold](https://github.com/tustvold))
 - Object Store \(AWS\): Support dynamically resolving S3 bucket region [\#4188](https://github.com/apache/arrow-rs/pull/4188) [[object-store](https://github.com/apache/arrow-rs/labels/object-store)] ([mr-brobot](https://github.com/mr-brobot))
 - Faster prefix match in object\_store path handling [\#4164](https://github.com/apache/arrow-rs/pull/4164) [[object-store](https://github.com/apache/arrow-rs/labels/object-store)] ([tustvold](https://github.com/tustvold))
 - Object Store \(AWS\): Support region configured via named profile [\#4161](https://github.com/apache/arrow-rs/pull/4161) [[object-store](https://github.com/apache/arrow-rs/labels/object-store)] ([mr-brobot](https://github.com/mr-brobot))
@@ -1154,7 +1154,7 @@
 - Relax path validation \(\#2355\) [\#2356](https://github.com/apache/arrow-rs/pull/2356) [[object-store](https://github.com/apache/arrow-rs/labels/object-store)] ([tustvold](https://github.com/tustvold))
 - Fix Copy from percent-encoded path \(\#2353\) [\#2354](https://github.com/apache/arrow-rs/pull/2354) [[object-store](https://github.com/apache/arrow-rs/labels/object-store)] ([tustvold](https://github.com/tustvold))
 - Add ObjectStore::get\_ranges \(\#2293\) [\#2336](https://github.com/apache/arrow-rs/pull/2336) [[object-store](https://github.com/apache/arrow-rs/labels/object-store)] ([tustvold](https://github.com/tustvold))
-- Remove vestigal ` object_store/.circleci/` [\#2337](https://github.com/apache/arrow-rs/pull/2337) ([alamb](https://github.com/alamb))
+- Remove vestigial ` object_store/.circleci/` [\#2337](https://github.com/apache/arrow-rs/pull/2337) ([alamb](https://github.com/alamb))
 - Handle symlinks in LocalFileSystem \(\#2206\) [\#2269](https://github.com/apache/arrow-rs/pull/2269) [[object-store](https://github.com/apache/arrow-rs/labels/object-store)] ([tustvold](https://github.com/tustvold))
 - Retry GCP requests on server error [\#2243](https://github.com/apache/arrow-rs/pull/2243) [[object-store](https://github.com/apache/arrow-rs/labels/object-store)] ([tustvold](https://github.com/tustvold))
 - Add LimitStore \(\#2175\) [\#2242](https://github.com/apache/arrow-rs/pull/2242) [[object-store](https://github.com/apache/arrow-rs/labels/object-store)] ([tustvold](https://github.com/tustvold))
diff --git a/_typos.toml b/_typos.toml
new file mode 100644
index 0000000..34cb2da
--- /dev/null
+++ b/_typos.toml
@@ -0,0 +1,31 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+[default]
+extend-ignore-identifiers-re = [
+    # GitHub username
+    "ethe",
+    # Identifier containing "Swith" as part of compound name
+    "SASwithSkipSignature",
+]
+
+extend-ignore-re = [
+    # Test string literals containing "fo" in specific test files
+    'delimiter\.push\("fo',
+    'Bytes::from\("fo',
+    'let prefix = Some\("fo"\);',
+]
diff --git a/src/azure/client.rs b/src/azure/client.rs
index 54ab307..7a7d6dc 100644
--- a/src/azure/client.rs
+++ b/src/azure/client.rs
@@ -455,7 +455,7 @@ async fn parse_blob_batch_delete_body(
 
         // Parse part response headers
         // Documentation mentions 5 headers and states that other standard HTTP headers
-        // may be provided, in order to not incurr in more complexity to support an arbitrary
+        // may be provided, in order to not incur in more complexity to support an arbitrary
         // amount of headers we chose a conservative amount and error otherwise
         // https://learn.microsoft.com/en-us/rest/api/storageservices/delete-blob?tabs=microsoft-entra-id#response-headers
         let mut headers = [httparse::EMPTY_HEADER; 48];
@@ -794,7 +794,7 @@ impl AzureClient {
     /// Creat an AzureSigner for generating SAS tokens (pre-signed urls).
     ///
     /// Depending on the type of credential, this will either use the account key or a user delegation key.
-    /// Since delegation keys are acquired ad-hoc, the signer aloows for signing multiple urls with the same key.
+    /// Since delegation keys are acquired ad-hoc, the signer allows for signing multiple urls with the same key.
     pub(crate) async fn signer(&self, expires_in: Duration) -> Result<AzureSigner> {
         let credential = self.get_credential().await?;
         let signed_start = chrono::Utc::now();
diff --git a/src/gcp/builder.rs b/src/gcp/builder.rs
index 48a5246..ece16ec 100644
--- a/src/gcp/builder.rs
+++ b/src/gcp/builder.rs
@@ -771,12 +771,12 @@ mod tests {
 
         let explicit_override = GoogleCloudStorageBuilder::new()
             .with_bucket_name("foo")
-            .with_base_url("https://explicitly-overriden:4443")
+            .with_base_url("https://explicitly-overridden:4443")
             .build()
             .unwrap();
         assert_eq!(
             explicit_override.client.config().base_url,
-            "https://explicitly-overriden:4443"
+            "https://explicitly-overridden:4443"
         );
 
         let url_in_credentials = GoogleCloudStorageBuilder::new()
@@ -791,13 +791,13 @@ mod tests {
 
         let explicit_override_and_credentials = GoogleCloudStorageBuilder::new()
             .with_bucket_name("foo")
-            .with_base_url("https://explicitly-overriden:4443") // this should take precedence
+            .with_base_url("https://explicitly-overridden:4443") // this should take precedence
             .with_service_account_key(FAKE_KEY_WITH_BASE_URL)
             .build()
             .unwrap();
         assert_eq!(
             explicit_override_and_credentials.client.config().base_url,
-            "https://explicitly-overriden:4443"
+            "https://explicitly-overridden:4443"
         );
     }
 
diff --git a/src/lib.rs b/src/lib.rs
index 0a7e509..54d51dd 100644
--- a/src/lib.rs
+++ b/src/lib.rs
@@ -1202,7 +1202,7 @@ as_ref_impl!(Box<T>);
 
 /// Extension trait for [`ObjectStore`] with convenience functions.
 ///
-/// See the [module-level documentation](crate) for a high leve overview and
+/// See the [module-level documentation](crate) for a high level overview and
 /// examples. See "contract" section within the [`ObjectStore`] documentation
 /// for more reasoning.
 ///