You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Dan Smith <ds...@pivotal.io> on 2015/11/11 22:40:16 UTC
Review Request 40200: GEODE-542: Send a function response after a
CancelException
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40200/
-----------------------------------------------------------
Review request for geode and Swapnil Bawaskar.
Repository: geode
Description
-------
There was a catch clause of a CancelException that was causing us not to
reply to a function call if a CacheClosedException was thrown from the
function. That caused as hang waiting for replies.
Diffs
-----
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/MemberFunctionStreamingMessage.java 9ea6f280d9569e0046d9a2ba370155d08e000a68
gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/MemberFunctionExecutionDUnitTest.java 129cd180da10c71139b13c212a3c84961938db50
Diff: https://reviews.apache.org/r/40200/diff/
Testing
-------
Thanks,
Dan Smith
Re: Review Request 40200: GEODE-542: Send a function response after a
CancelException
Posted by Swapnil Bawaskar <sb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40200/#review106166
-----------------------------------------------------------
Ship it!
Ship It!
- Swapnil Bawaskar
On Nov. 11, 2015, 9:40 p.m., Dan Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40200/
> -----------------------------------------------------------
>
> (Updated Nov. 11, 2015, 9:40 p.m.)
>
>
> Review request for geode and Swapnil Bawaskar.
>
>
> Repository: geode
>
>
> Description
> -------
>
> There was a catch clause of a CancelException that was causing us not to
> reply to a function call if a CacheClosedException was thrown from the
> function. That caused as hang waiting for replies.
>
>
> Diffs
> -----
>
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/MemberFunctionStreamingMessage.java 9ea6f280d9569e0046d9a2ba370155d08e000a68
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/MemberFunctionExecutionDUnitTest.java 129cd180da10c71139b13c212a3c84961938db50
>
> Diff: https://reviews.apache.org/r/40200/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Smith
>
>