You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2014/05/09 23:02:47 UTC
Re: Review Request 21280: pig.properties should set
pig.location.check.strict to false
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21280/
-----------------------------------------------------------
(Updated May 9, 2014, 5:02 p.m.)
Review request for Ambari, Andrew Onischuk and Sid Wagle.
Changes
-------
Updating Group.
Bugs: https://issues.apache.org/jira/browse/AMBARI-5720
https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/AMBARI-5720
Repository: ambari
Description
-------
In order to update the properties that the pig client uses, it was necessary to change how the pig.properties were handed to the agent. We now expose pig.properties as part of the StackConfiguration so that the web client and other clients can modify it, if necessary. This property file can then be sent back in the command in order for the python scripts to process it and write it out to disk.
In the event that the client does not send it back, the python script will default to writing out the bare minimum parameters to the pig.properties file.
Diffs
-----
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/configuration/pig-properties.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/configuration/pig.properties 01000b5
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/metainfo.xml 7db411b
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/package/scripts/params.py ab52cac
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/package/scripts/pig.py bf0ccd9
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/package/templates/pig.properties.j2 90a32b1
ambari-server/src/main/resources/stacks/HDP/2.1/services/PIG/configuration/pig-properties.xml PRE-CREATION
ambari-server/src/test/python/stacks/2.0.6/PIG/test_pig_client.py 5ff3b4f
ambari-server/src/test/python/stacks/2.0.6/configs/default.json 7a76996
ambari-server/src/test/python/stacks/2.0.6/configs/secured.json 9889426
Diff: https://reviews.apache.org/r/21280/diff/
Testing
-------
Server Python
----------------------------------------------------------------------
Ran 203 tests in 0.485s
OK
----------------------------------------------------------------------
Total run:548
Total errors:0
Total failures:0
OK
Thanks,
Jonathan Hurley
Re: Review Request 21280: pig.properties should set
pig.location.check.strict to false
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21280/#review42710
-----------------------------------------------------------
Ship it!
Ship It!
- Sid Wagle
On May 9, 2014, 9:02 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21280/
> -----------------------------------------------------------
>
> (Updated May 9, 2014, 9:02 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk and Sid Wagle.
>
>
> Bugs: https://issues.apache.org/jira/browse/AMBARI-5720
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/AMBARI-5720
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In order to update the properties that the pig client uses, it was necessary to change how the pig.properties were handed to the agent. We now expose pig.properties as part of the StackConfiguration so that the web client and other clients can modify it, if necessary. This property file can then be sent back in the command in order for the python scripts to process it and write it out to disk.
>
> In the event that the client does not send it back, the python script will default to writing out the bare minimum parameters to the pig.properties file.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/configuration/pig-properties.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/configuration/pig.properties 01000b5
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/metainfo.xml 7db411b
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/package/scripts/params.py ab52cac
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/package/scripts/pig.py bf0ccd9
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/package/templates/pig.properties.j2 90a32b1
> ambari-server/src/main/resources/stacks/HDP/2.1/services/PIG/configuration/pig-properties.xml PRE-CREATION
> ambari-server/src/test/python/stacks/2.0.6/PIG/test_pig_client.py 5ff3b4f
> ambari-server/src/test/python/stacks/2.0.6/configs/default.json 7a76996
> ambari-server/src/test/python/stacks/2.0.6/configs/secured.json 9889426
>
> Diff: https://reviews.apache.org/r/21280/diff/
>
>
> Testing
> -------
>
> Server Python
> ----------------------------------------------------------------------
> Ran 203 tests in 0.485s
>
> OK
> ----------------------------------------------------------------------
> Total run:548
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Jonathan Hurley
>
>