You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by gfalcone <gi...@git.apache.org> on 2017/02/21 16:50:47 UTC
[GitHub] zeppelin pull request #2051: [ZEPPELIN-1968] Added property to disable hive ...
GitHub user gfalcone opened a pull request:
https://github.com/apache/zeppelin/pull/2051
[ZEPPELIN-1968] Added property to disable hive user impersonation
### What is this PR for?
Added new property "hive.proxy.user" to disable hive impersonation (on some clusters, this option is disabled) in order to make Hive Interpreter even without this
### What type of PR is it?
Feature
### Todos
### What is the Jira issue?
* Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/
* Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. [ZEPPELIN-533]
### How should this be tested?
Set "hive.proxy.user" to true in the jdbc interpreter setttings, and you should see "Using hive proxy user" in the jdbc logs.
If "hive.proxy.user" has another value, this is not mentionned in the logs
You can also test with the appropriate hive configuration, but this could take longer :)
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? Yes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gfalcone/zeppelin hive_impersonation
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2051.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2051
----
commit d6f0c625c5475dbf182f8886662b4a7afaa06184
Author: Paolo Genissel <pa...@1000mercis.com>
Date: 2017-02-21T16:29:21Z
Added property to disable hive user impersonation
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2051: [ZEPPELIN-1968] Added property to disable hive user im...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2051
Merging this if no more discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2051: [ZEPPELIN-1968] Added property to disable hive user im...
Posted by gfalcone <gi...@git.apache.org>.
Github user gfalcone commented on the issue:
https://github.com/apache/zeppelin/pull/2051
@prabhjyotsingh thank you for reviewing, just pushed the doc :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2051: [ZEPPELIN-1968] Added property to disable hive user im...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2051
This looks OK to me, can you add a line note on https://github.com/apache/zeppelin/blob/master/docs/interpreter/jdbc.md#apache-hive to update the documentation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2051: [ZEPPELIN-1968] Added property to disable hive user im...
Posted by gfalcone <gi...@git.apache.org>.
Github user gfalcone commented on the issue:
https://github.com/apache/zeppelin/pull/2051
@prabhjyotsingh right, didn't see that
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2051: [ZEPPELIN-1968] Added property to disable hive user im...
Posted by gfalcone <gi...@git.apache.org>.
Github user gfalcone commented on the issue:
https://github.com/apache/zeppelin/pull/2051
CI passed all the tests : https://travis-ci.org/gfalcone/zeppelin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2051: [ZEPPELIN-1968] Added property to disable hive user im...
Posted by gfalcone <gi...@git.apache.org>.
Github user gfalcone commented on the issue:
https://github.com/apache/zeppelin/pull/2051
@prabhjyotsingh the CI passed !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2051: [ZEPPELIN-1968] Added property to disable hive user im...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2051
Sure thank you @gfalcone, will merge this soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2051: [ZEPPELIN-1968] Added property to disable hive user im...
Posted by gfalcone <gi...@git.apache.org>.
Github user gfalcone commented on the issue:
https://github.com/apache/zeppelin/pull/2051
OK, so I deleted that line because I realized that we were in the condition where it's not the hive jdbc, so we don't have to worry about that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2051: [ZEPPELIN-1968] Added property to disable hive user im...
Posted by gfalcone <gi...@git.apache.org>.
Github user gfalcone commented on the issue:
https://github.com/apache/zeppelin/pull/2051
@prabhjyotsingh is everything good for you :) ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2051: [ZEPPELIN-1968] Added property to disable hive user im...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2051
Yes, LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2051: [ZEPPELIN-1968] Added property to disable hive ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2051
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---