[jira] [Commented] (MWRAPPER-47) Use name wrapperUrl consistently in Maven Wrapper files/scripts

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MWRAPPER-47?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17480613#comment-17480613 ] 

ASF GitHub Bot commented on MWRAPPER-47:
----------------------------------------

jimisola opened a new pull request #14:
URL: https://github.com/apache/maven-wrapper/pull/14


   Replaced jarUrl with wrapperUrl in mvnw
   
   My first maven contribution in 15 years or so. Please advise if I missed out on something.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Use name wrapperUrl consistently in Maven Wrapper files/scripts
> ---------------------------------------------------------------
>
>                 Key: MWRAPPER-47
>                 URL: https://issues.apache.org/jira/browse/MWRAPPER-47
>             Project: Maven Wrapper
>          Issue Type: Improvement
>          Components: Maven Wrapper Scripts
>    Affects Versions: 3.1.0
>            Reporter: Jimisola Laursen
>            Priority: Low
>              Labels: up-for-grabs
>             Fix For: 3.1.1
>
>
> maven-wrapper.properties has two properties: *wrapperUrl* and distributionUrl
> However, in the mvnw script the wrapperUrl is stored as jarUrl (no need for confusion) and after download it is referred to as wrapperJarPath.
> Rename jarUrl to wrapperUrl in mvn[.cmd] for consistency.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)