You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "theweakgod (via GitHub)" <gi...@apache.org> on 2023/11/11 03:13:26 UTC
[PR] [2023-11-11][optional port for admin schema] [apisix]
theweakgod opened a new pull request, #10477:
URL: https://github.com/apache/apisix/pull/10477
### Description
there is a bug in the schema check of nodes when admin-api saves the upstream configuration.
Fixes # ([issue](https://github.com/apache/apisix/issues/10455))
### Checklist
- [ ] I have explained the need for this PR and the problem it solves
- [ ] I have explained the changes or the new features added to this PR
- [ ] I have added tests corresponding to this change
- [ ] I have updated the documentation to reflect this change
- [ ] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
<!--
Note
1. Mark the PR as draft until it's ready to be reviewed.
2. Always add/update tests for any changes unless you have a good reason.
3. Always update the documentation to reflect the changes made in the PR.
4. Make a new commit to resolve conversations instead of `push -f`.
5. To resolve merge conflicts, merge master instead of rebasing.
6. Use "request review" to notify the reviewer after making changes.
7. Only a reviewer can mark a conversation as resolved.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: optional port for nod schema [apisix]
Posted by "Revolyssup (via GitHub)" <gi...@apache.org>.
Revolyssup commented on code in PR #10477:
URL: https://github.com/apache/apisix/pull/10477#discussion_r1398827471
##########
t/admin/schema-validate.t:
##########
@@ -398,3 +398,44 @@ location /t {
--- error_code: 400
--- response
{"error_msg":"allOf 1 failed: value should match only one schema, but matches none"}
+
+
+
+=== TEST 13: Check node_schema optional port
+--- config
+ location /t {
+ content_by_lua_block {
+ local t = require("lib.test_admin").test
+ headers = {}
+ headers["X-API-KEY"] = "edd1c9f034335f136f87ad84b625c8f1"
+ local code, body = t('/apisix/admin/routes/1',
+ ngx.HTTP_PUT,
+ {
+ uri = "/ip",
+ upstream = {
+ type = "roundrobin",
+ nodes = {
+ { host = "httpbin.org", weight = 1,}
+ }
+ },
+ methods = {"GET"},
+ }, nil, headers
+ )
+
+ if code >= 300 then
+ ngx.status = code
+ end
+ ngx.say(body)
+
+ }
+ }
+--- request
+GET /t
+--- response_body
+passed
+
+
+
+=== TEST 14: Test route upstream
+--- request
+GET /ip
Review Comment:
okay
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: optional port for nod schema [apisix]
Posted by "theweakgod (via GitHub)" <gi...@apache.org>.
theweakgod commented on PR #10477:
URL: https://github.com/apache/apisix/pull/10477#issuecomment-1809579421
> @theweakgod Could you add a test case to cover this?
done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: optional port for nod schema [apisix]
Posted by "Revolyssup (via GitHub)" <gi...@apache.org>.
Revolyssup commented on PR #10477:
URL: https://github.com/apache/apisix/pull/10477#issuecomment-1818234728
@theweakgod It was a flaky test. I rerun the CI and it passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: optional port for nod schema [apisix]
Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 commented on PR #10477:
URL: https://github.com/apache/apisix/pull/10477#issuecomment-1815928326
please make the ci pass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: optional port for nod schema [apisix]
Posted by "theweakgod (via GitHub)" <gi...@apache.org>.
theweakgod commented on PR #10477:
URL: https://github.com/apache/apisix/pull/10477#issuecomment-1816204426
> 请让 ci 通过
ok，updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: optional port for nod schema [apisix]
Posted by "theweakgod (via GitHub)" <gi...@apache.org>.
theweakgod commented on code in PR #10477:
URL: https://github.com/apache/apisix/pull/10477#discussion_r1398853400
##########
t/admin/schema-validate.t:
##########
@@ -398,3 +398,44 @@ location /t {
--- error_code: 400
--- response
{"error_msg":"allOf 1 failed: value should match only one schema, but matches none"}
+
+
+
+=== TEST 13: Check node_schema optional port
+--- config
+ location /t {
+ content_by_lua_block {
+ local t = require("lib.test_admin").test
+ headers = {}
+ headers["X-API-KEY"] = "edd1c9f034335f136f87ad84b625c8f1"
+ local code, body = t('/apisix/admin/routes/1',
+ ngx.HTTP_PUT,
+ {
+ uri = "/ip",
+ upstream = {
+ type = "roundrobin",
+ nodes = {
+ { host = "httpbin.org", weight = 1,}
+ }
+ },
+ methods = {"GET"},
+ }, nil, headers
+ )
+
+ if code >= 300 then
+ ngx.status = code
+ end
+ ngx.say(body)
+
+ }
+ }
+--- request
+GET /t
+--- response_body
+passed
+
+
+
+=== TEST 14: Test route upstream
+--- request
+GET /ip
Review Comment:
> okay
I remove some useless code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: optional port for nod schema [apisix]
Posted by "theweakgod (via GitHub)" <gi...@apache.org>.
theweakgod commented on PR #10477:
URL: https://github.com/apache/apisix/pull/10477#issuecomment-1810079388
@monkeyDluffy6017 @shreemaan-abhishek all done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: optional port for nod schema [apisix]
Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 commented on code in PR #10477:
URL: https://github.com/apache/apisix/pull/10477#discussion_r1392014096
##########
t/core/schema_def_optional_port.t:
##########
Review Comment:
Yeah, you should prove that the route could work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: optional port for nod schema [apisix]
Posted by "theweakgod (via GitHub)" <gi...@apache.org>.
theweakgod commented on PR #10477:
URL: https://github.com/apache/apisix/pull/10477#issuecomment-1818237743
> @theweakgod It was a flaky test. I rerun the CI and it passed.
Ok, I see.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: optional port for nod schema [apisix]
Posted by "theweakgod (via GitHub)" <gi...@apache.org>.
theweakgod commented on PR #10477:
URL: https://github.com/apache/apisix/pull/10477#issuecomment-1809454962
> @theweakgod Could you add a test case to cover this?
Ok, can you tell me how to add a test case. Or some doc that tells me how to add it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: optional port for nod schema [apisix]
Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 commented on code in PR #10477:
URL: https://github.com/apache/apisix/pull/10477#discussion_r1399957657
##########
t/admin/schema-validate.t:
##########
@@ -398,3 +398,42 @@ location /t {
--- error_code: 400
--- response
{"error_msg":"allOf 1 failed: value should match only one schema, but matches none"}
+
+
+
+=== TEST 13: Check node_schema optional port
+--- config
+ location /t {
+ content_by_lua_block {
+ local t = require("lib.test_admin").test
+ local code, body = t('/apisix/admin/routes',
+ ngx.HTTP_POST,
+ {
+ uri = "/ip",
+ upstream = {
+ type = "roundrobin",
+ nodes = {
+ { host = "nghttp2.org", weight = 1,}
Review Comment:
use `127.0.0.1:1980` instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: optional port for nod schema [apisix]
Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 commented on code in PR #10477:
URL: https://github.com/apache/apisix/pull/10477#discussion_r1399960808
##########
t/admin/schema-validate.t:
##########
@@ -398,3 +398,42 @@ location /t {
--- error_code: 400
--- response
{"error_msg":"allOf 1 failed: value should match only one schema, but matches none"}
+
+
+
+=== TEST 13: Check node_schema optional port
+--- config
+ location /t {
+ content_by_lua_block {
+ local t = require("lib.test_admin").test
+ local code, body = t('/apisix/admin/routes',
+ ngx.HTTP_POST,
+ {
+ uri = "/ip",
+ upstream = {
+ type = "roundrobin",
+ nodes = {
+ { host = "nghttp2.org", weight = 1,}
+ }
+ },
+ methods = {"GET"},
+ }
+ )
+
+ if code >= 300 then
+ ngx.status = code
+ end
+ ngx.say(body)
+
+ }
+ }
+--- request
+GET /t
+--- response_body
+passed
+
+
+
+=== TEST 14: Test route upstream
+--- request
+GET /ip
Review Comment:
We should check the response body, like this
```
=== TEST 8: `url` exist and `route_id` is 1
--- request
GET /hello
--- response_body
hello world
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: optional port for nod schema [apisix]
Posted by "theweakgod (via GitHub)" <gi...@apache.org>.
theweakgod commented on PR #10477:
URL: https://github.com/apache/apisix/pull/10477#issuecomment-1818141228
> please make the ci pass
Is this error a problem with the test file? What do I need to do?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: optional port for nod schema [apisix]
Posted by "yujiapingyu (via GitHub)" <gi...@apache.org>.
yujiapingyu commented on PR #10477:
URL: https://github.com/apache/apisix/pull/10477#issuecomment-1806719479
cheers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: optional port for nod schema [apisix]
Posted by "theweakgod (via GitHub)" <gi...@apache.org>.
theweakgod commented on PR #10477:
URL: https://github.com/apache/apisix/pull/10477#issuecomment-1809498644
> https://apisix.apache.org/blog/2022/06/27/getting-start-with-apisix-test-cases/
thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: optional port for nod schema [apisix]
Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 commented on code in PR #10477:
URL: https://github.com/apache/apisix/pull/10477#discussion_r1398770600
##########
t/admin/schema-validate.t:
##########
@@ -398,3 +398,44 @@ location /t {
--- error_code: 400
--- response
{"error_msg":"allOf 1 failed: value should match only one schema, but matches none"}
+
+
+
+=== TEST 13: Check node_schema optional port
+--- config
+ location /t {
+ content_by_lua_block {
+ local t = require("lib.test_admin").test
+ headers = {}
+ headers["X-API-KEY"] = "edd1c9f034335f136f87ad84b625c8f1"
+ local code, body = t('/apisix/admin/routes/1',
+ ngx.HTTP_PUT,
+ {
+ uri = "/ip",
+ upstream = {
+ type = "roundrobin",
+ nodes = {
+ { host = "httpbin.org", weight = 1,}
+ }
+ },
+ methods = {"GET"},
+ }, nil, headers
+ )
+
+ if code >= 300 then
+ ngx.status = code
+ end
+ ngx.say(body)
+
+ }
+ }
+--- request
+GET /t
+--- response_body
+passed
+
+
+
+=== TEST 14: Test route upstream
+--- request
+GET /ip
Review Comment:
@Revolyssup Would you like to update these test cases? it is better not to use `httpbin.org`, it is unstable, and we could check the response body like the other test cases, and no need to add `X-API-KEY` in the request header and so on
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: optional port for nod schema [apisix]
Posted by "theweakgod (via GitHub)" <gi...@apache.org>.
theweakgod commented on PR #10477:
URL: https://github.com/apache/apisix/pull/10477#issuecomment-1820122126
> @theweakgod Nice job!
^ ^. thank you very much for your help.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: optional port for nod schema [apisix]
Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 commented on PR #10477:
URL: https://github.com/apache/apisix/pull/10477#issuecomment-1809496593
@theweakgod you could refer to https://apisix.apache.org/blog/2022/06/27/getting-start-with-apisix-test-cases/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: optional port for nod schema [apisix]
Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 commented on code in PR #10477:
URL: https://github.com/apache/apisix/pull/10477#discussion_r1392011882
##########
t/core/schema_def_optional_port.t:
##########
Review Comment:
No need to add a new test file, add it here: https://github.com/apache/apisix/blob/master/t/admin/schema-validate.t
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: optional port for nod schema [apisix]
Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 merged PR #10477:
URL: https://github.com/apache/apisix/pull/10477
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: optional port for nod schema [apisix]
Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 commented on PR #10477:
URL: https://github.com/apache/apisix/pull/10477#issuecomment-1809448276
@theweakgod Could you add a test case to cover this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: optional port for nod schema [apisix]
Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 commented on code in PR #10477:
URL: https://github.com/apache/apisix/pull/10477#discussion_r1392011303
##########
t/core/schema_def_optional_port.t:
##########
@@ -0,0 +1,89 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+use t::APISIX 'no_plan';
+
+repeat_each(2);
+no_long_string();
+no_root_location();
+log_level("info");
+
+add_block_preprocessor(sub {
+ my ($block) = @_;
+
+ if (!$block->request) {
+ $block->set_value("request", "GET /t");
+ }
+
+ if (!$block->error_log && !$block->no_error_log) {
+ $block->set_value("no_error_log", "[error]\n[alert]");
+ }
+});
+
+run_tests;
+
+__DATA__
+
+=== TEST 1: Sanity check node_schema optional port
+--- config
+ location /t {
+ content_by_lua_block {
+ local schema_def = require("apisix.schema_def")
+ local core = require("apisix.core")
+
+
Review Comment:
redundant blank
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: optional port for nod schema [apisix]
Posted by "shreemaan-abhishek (via GitHub)" <gi...@apache.org>.
shreemaan-abhishek commented on PR #10477:
URL: https://github.com/apache/apisix/pull/10477#issuecomment-1809584332
@theweakgod, the test case you added aren't up to the mark. Please demonstrate using domain name in the nodes without port is acceptable and accessing a route that uses such upstream does not fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: optional port for nod schema [apisix]
Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 commented on code in PR #10477:
URL: https://github.com/apache/apisix/pull/10477#discussion_r1399958508
##########
t/admin/schema-validate.t:
##########
@@ -398,3 +398,42 @@ location /t {
--- error_code: 400
--- response
{"error_msg":"allOf 1 failed: value should match only one schema, but matches none"}
+
+
+
+=== TEST 13: Check node_schema optional port
+--- config
+ location /t {
+ content_by_lua_block {
+ local t = require("lib.test_admin").test
+ local code, body = t('/apisix/admin/routes',
+ ngx.HTTP_POST,
+ {
+ uri = "/ip",
Review Comment:
you could search `127.0.0.1:1980` in the project, and find what uri is better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: optional port for nod schema [apisix]
Posted by "theweakgod (via GitHub)" <gi...@apache.org>.
theweakgod commented on code in PR #10477:
URL: https://github.com/apache/apisix/pull/10477#discussion_r1399960356
##########
t/admin/schema-validate.t:
##########
@@ -398,3 +398,42 @@ location /t {
--- error_code: 400
--- response
{"error_msg":"allOf 1 failed: value should match only one schema, but matches none"}
+
+
+
+=== TEST 13: Check node_schema optional port
+--- config
+ location /t {
+ content_by_lua_block {
+ local t = require("lib.test_admin").test
+ local code, body = t('/apisix/admin/routes',
+ ngx.HTTP_POST,
+ {
+ uri = "/ip",
Review Comment:
OK, done. thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: optional port for nod schema [apisix]
Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 commented on PR #10477:
URL: https://github.com/apache/apisix/pull/10477#issuecomment-1820121063
@theweakgod Nice job!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: optional port for nod schema [apisix]
Posted by "shreemaan-abhishek (via GitHub)" <gi...@apache.org>.
shreemaan-abhishek commented on code in PR #10477:
URL: https://github.com/apache/apisix/pull/10477#discussion_r1392011416
##########
t/core/schema_def_optional_port.t:
##########
Review Comment:
@theweakgod, the test case you added aren't up to the mark. Please demonstrate using domain name in the nodes without port is acceptable and accessing a route that uses such upstream does not fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org