[GitHub] [iceberg] rdblue commented on a diff in pull request #5998: Core: Deprecate HTTPClientFactory / Allow configuring ObjectMapper for HTTPClient

[GitBox <gi...@apache.org>]

rdblue commented on code in PR #5998:
URL: https://github.com/apache/iceberg/pull/5998#discussion_r997304439


##########
core/src/main/java/org/apache/iceberg/rest/RESTCatalog.java:
##########
@@ -46,7 +47,9 @@
   private final SupportsNamespaces nsDelegate;
 
   public RESTCatalog() {
-    this(SessionCatalog.SessionContext.createEmpty(), new HTTPClientFactory());
+    this(
+        SessionCatalog.SessionContext.createEmpty(),
+        config -> HTTPClient.builder().uri(config.get(CatalogProperties.URI)).build());

Review Comment:
   Do we need to call `uri` or can that be pulled out of the config by the builder?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org