[GitHub] [spark] yabola commented on a diff in pull request #37545: [SPARK-40113][SQL] Reactor ParquetScanBuilder DataSourceV2 interface implementations

[GitBox <gi...@apache.org>]

yabola commented on code in PR #37545:
URL: https://github.com/apache/spark/pull/37545#discussion_r947529851


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/parquet/ParquetScanBuilder.scala:
##########
@@ -68,25 +73,12 @@ case class ParquetScanBuilder(
         // The rebase mode doesn't matter here because the filters are used to determine
         // whether they is convertible.
         RebaseSpec(LegacyBehaviorPolicy.CORRECTED))
-      parquetFilters.convertibleFilters(pushedDataFilters).toArray
+      parquetFilters.convertibleFilters(dataFilters).toArray
     } else {
       Array.empty[Filter]

Review Comment:
   @cloud-fan `FileScanBuilder#pushDataFilters` should return the filters currently supported by the datasource. I refer to the implementation of `OrcScanBuilder` and `JsonScanBuilder`. And this is consistent with the previous parquet implementation logic.
   
   `FileScanBuilder#pushFilters` should always return `dataFilters`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org