You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu> on 2021/06/24 01:06:29 UTC
Change in asterixdb[mad-hatter]: [NO ISSUE][MD] Ensure metadata node is initialized
From Murtadha Hubail <mh...@apache.org>:
Murtadha Hubail has uploaded this change for review. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/12023 )
Change subject: [NO ISSUE][MD] Ensure metadata node is initialized
......................................................................
[NO ISSUE][MD] Ensure metadata node is initialized
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- Before attempting to being any metadata transaction, ensure
the metadata node has been bound to avoid NPE.
Change-Id: Ic54314e9da42b4111a1aab53d1ec355ad13922e1
Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10444
Integration-Tests: Jenkins <je...@fulliautomatix.ics.uci.edu>
Tested-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
Reviewed-by: Murtadha Hubail <mh...@apache.org>
Reviewed-by: Ali Alsuliman <al...@gmail.com>
(cherry picked from commit e8428051a7550578e2b28f5987e87ede41c83832)
---
M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataManager.java
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/23/12023/1
diff --git a/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataManager.java b/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataManager.java
index e5ee163..362ead8 100644
--- a/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataManager.java
+++ b/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataManager.java
@@ -129,6 +129,11 @@
@Override
public MetadataTransactionContext beginTransaction() throws RemoteException {
+ try {
+ INSTANCE.init();
+ } catch (HyracksDataException e) {
+ throw new ACIDException(e);
+ }
TxnId txnId = createTxnId();
metadataNode.beginTransaction(txnId);
return new MetadataTransactionContext(txnId);
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/12023
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: mad-hatter
Gerrit-Change-Id: Ic54314e9da42b4111a1aab53d1ec355ad13922e1
Gerrit-Change-Number: 12023
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-MessageType: newchange
Change in asterixdb[mad-hatter]: [NO ISSUE][MD] Ensure metadata node is initialized
Posted by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>.
From Murtadha Hubail <mh...@apache.org>:
Murtadha Hubail has submitted this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/12023 )
Change subject: [NO ISSUE][MD] Ensure metadata node is initialized
......................................................................
[NO ISSUE][MD] Ensure metadata node is initialized
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- Before attempting to being any metadata transaction, ensure
the metadata node has been bound to avoid NPE.
Change-Id: Ic54314e9da42b4111a1aab53d1ec355ad13922e1
Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10444
Integration-Tests: Jenkins <je...@fulliautomatix.ics.uci.edu>
Tested-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
Reviewed-by: Murtadha Hubail <mh...@apache.org>
Reviewed-by: Ali Alsuliman <al...@gmail.com>
(cherry picked from commit e8428051a7550578e2b28f5987e87ede41c83832)
Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/12023
---
M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataManager.java
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
Ali Alsuliman: Looks good to me, approved
Jenkins: Verified; Verified
Anon. E. Moose #1000171:
diff --git a/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataManager.java b/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataManager.java
index e5ee163..362ead8 100644
--- a/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataManager.java
+++ b/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataManager.java
@@ -129,6 +129,11 @@
@Override
public MetadataTransactionContext beginTransaction() throws RemoteException {
+ try {
+ INSTANCE.init();
+ } catch (HyracksDataException e) {
+ throw new ACIDException(e);
+ }
TxnId txnId = createTxnId();
metadataNode.beginTransaction(txnId);
return new MetadataTransactionContext(txnId);
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/12023
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: mad-hatter
Gerrit-Change-Id: Ic54314e9da42b4111a1aab53d1ec355ad13922e1
Gerrit-Change-Number: 12023
Gerrit-PatchSet: 2
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Ali Alsuliman <al...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <mh...@apache.org>
Gerrit-MessageType: merged
Change in asterixdb[mad-hatter]: [NO ISSUE][MD] Ensure metadata node is initialized
Posted by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>.
From Murtadha Hubail <mh...@apache.org>:
Murtadha Hubail has uploaded this change for review. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/12023 )
Change subject: [NO ISSUE][MD] Ensure metadata node is initialized
......................................................................
[NO ISSUE][MD] Ensure metadata node is initialized
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- Before attempting to being any metadata transaction, ensure
the metadata node has been bound to avoid NPE.
Change-Id: Ic54314e9da42b4111a1aab53d1ec355ad13922e1
Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10444
Integration-Tests: Jenkins <je...@fulliautomatix.ics.uci.edu>
Tested-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
Reviewed-by: Murtadha Hubail <mh...@apache.org>
Reviewed-by: Ali Alsuliman <al...@gmail.com>
(cherry picked from commit e8428051a7550578e2b28f5987e87ede41c83832)
---
M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataManager.java
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/23/12023/1
diff --git a/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataManager.java b/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataManager.java
index e5ee163..362ead8 100644
--- a/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataManager.java
+++ b/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataManager.java
@@ -129,6 +129,11 @@
@Override
public MetadataTransactionContext beginTransaction() throws RemoteException {
+ try {
+ INSTANCE.init();
+ } catch (HyracksDataException e) {
+ throw new ACIDException(e);
+ }
TxnId txnId = createTxnId();
metadataNode.beginTransaction(txnId);
return new MetadataTransactionContext(txnId);
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/12023
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: mad-hatter
Gerrit-Change-Id: Ic54314e9da42b4111a1aab53d1ec355ad13922e1
Gerrit-Change-Number: 12023
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-MessageType: newchange
Change in asterixdb[mad-hatter]: [NO ISSUE][MD] Ensure metadata node is initialized
Posted by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>.
Anon. E. Moose #1000171 has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/12023 )
Change subject: [NO ISSUE][MD] Ensure metadata node is initialized
......................................................................
Patch Set 1: Contrib+1
Analytics Compatibility Tests Successful
https://cbjenkins.page.link/dCuvxd9N2wenDbBi9 : SUCCESS
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/12023
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: mad-hatter
Gerrit-Change-Id: Ic54314e9da42b4111a1aab53d1ec355ad13922e1
Gerrit-Change-Number: 12023
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Thu, 24 Jun 2021 03:31:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Change in asterixdb[mad-hatter]: [NO ISSUE][MD] Ensure metadata node is initialized
Posted by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>.
From Jenkins <je...@fulliautomatix.ics.uci.edu>:
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/12023 )
Change subject: [NO ISSUE][MD] Ensure metadata node is initialized
......................................................................
Patch Set 1: Integration-Tests+1
Integration Tests Successful
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/12117/ : SUCCESS
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/12023
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: mad-hatter
Gerrit-Change-Id: Ic54314e9da42b4111a1aab53d1ec355ad13922e1
Gerrit-Change-Number: 12023
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-CC: Anon. E. Moose #1000171
Gerrit-Comment-Date: Thu, 24 Jun 2021 02:18:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment