You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/04/10 06:05:00 UTC

[GitHub] [incubator-seatunnel] kezhenxu94 commented on pull request #1453: [Hotfix][ci] Sort dependencies to pass the ci in known-dependencies.txt

kezhenxu94 commented on PR #1453:
URL: https://github.com/apache/incubator-seatunnel/pull/1453#issuecomment-1094190596

   @asdf2014 please.... this is not a problem of sorting... did you check the detail or just want a commit only? Did you try in the original PR that this would fix the problem? Did you see the comment 👇 that I've intentionally wrote 
   
   > 2. Unify the `sort` behaviour: here we'll sort them again in case that the behaviour of `sort`
   > command in target OS is different from what we used to sort the file `known-dependencies.txt`, i.e. "sort the two file
   > using the same command (and default arguments)"
   
   https://github.com/apache/incubator-seatunnel/blob/220c0a61840c870e66891a8c78b3c0ed072c6e80/tools/dependencies/checkLicense.sh#L35-L39
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org