You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/04/17 08:59:11 UTC

[GitHub] [kafka] wenbingshen commented on a change in pull request #10551: MINOR:Remove nonsense test line from TopicCommandTest

wenbingshen commented on a change in pull request #10551:
URL: https://github.com/apache/kafka/pull/10551#discussion_r615229878



##########
File path: core/src/test/scala/unit/kafka/admin/TopicCommandWithAdminClientTest.scala
##########
@@ -736,7 +735,6 @@ class TopicCommandWithAdminClientTest extends KafkaServerTestHarness with Loggin
       topicService.describeTopic(new TopicCommandOptions(Array("--topic", testTopicName))))
     val rows = output.split("\n")
     assertEquals(2, rows.size)
-    rows(0).startsWith(s"Topic:$testTopicName\tPartitionCount:1")

Review comment:
       Thanks for your commont. Due to the introduction of topicId, this will cause assert to fail. We can’t get the topicId in advance, so we can use `assertTrue(rows(0).startsWith(s"\tTopic: $testTopicName"))`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org