You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shiro.apache.org by "Nicolas Rougé (JIRA)" <ji...@apache.org> on 2012/07/16 16:38:33 UTC

[jira] [Created] (SHIRO-375) Basic authentication issue when using COLON character

Nicolas Rougé created SHIRO-375:
-----------------------------------

             Summary: Basic authentication issue when using COLON character
                 Key: SHIRO-375
                 URL: https://issues.apache.org/jira/browse/SHIRO-375
             Project: Shiro
          Issue Type: Bug
          Components: Authentication (log-in), Web
    Affects Versions: 1.2.0, 1.1.0
            Reporter: Nicolas Rougé
             Fix For: 1.3.0, 2.0.0




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Commented] (SHIRO-375) Basic authentication issue when using COLON character

Posted by "Nicolas Rougé (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHIRO-375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13415338#comment-13415338 ] 

Nicolas Rougé commented on SHIRO-375:
-------------------------------------

You're right, that does the same.
                
> Basic authentication issue when using COLON character
> -----------------------------------------------------
>
>                 Key: SHIRO-375
>                 URL: https://issues.apache.org/jira/browse/SHIRO-375
>             Project: Shiro
>          Issue Type: Bug
>          Components: Authentication (log-in), Web
>    Affects Versions: 1.1.0, 1.2.0
>            Reporter: Nicolas Rougé
>         Attachments: BasicHttpAuthenticationFilter.patch
>
>
> A user with a COLON character in his password cannot connect to a Shiro protected application when using Basic authentication. The problem is in the method that splits the username and password.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Resolved] (SHIRO-375) Basic authentication issue when using COLON character

Posted by "Jared Bunting (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHIRO-375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jared Bunting resolved SHIRO-375.
---------------------------------

       Resolution: Fixed
    Fix Version/s: 1.3.0
                   1.2.1

Test and fix have been added to both the 1.2.x branch and trunk.
                
> Basic authentication issue when using COLON character
> -----------------------------------------------------
>
>                 Key: SHIRO-375
>                 URL: https://issues.apache.org/jira/browse/SHIRO-375
>             Project: Shiro
>          Issue Type: Bug
>          Components: Authentication (log-in), Web
>    Affects Versions: 1.1.0, 1.2.0
>            Reporter: Nicolas Rougé
>            Assignee: Jared Bunting
>             Fix For: 1.2.1, 1.3.0
>
>         Attachments: BasicHttpAuthenticationFilter.patch
>
>
> A user with a COLON character in his password cannot connect to a Shiro protected application when using Basic authentication. The problem is in the method that splits the username and password.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Assigned] (SHIRO-375) Basic authentication issue when using COLON character

Posted by "Jared Bunting (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHIRO-375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jared Bunting reassigned SHIRO-375:
-----------------------------------

    Assignee: Jared Bunting
    
> Basic authentication issue when using COLON character
> -----------------------------------------------------
>
>                 Key: SHIRO-375
>                 URL: https://issues.apache.org/jira/browse/SHIRO-375
>             Project: Shiro
>          Issue Type: Bug
>          Components: Authentication (log-in), Web
>    Affects Versions: 1.1.0, 1.2.0
>            Reporter: Nicolas Rougé
>            Assignee: Jared Bunting
>         Attachments: BasicHttpAuthenticationFilter.patch
>
>
> A user with a COLON character in his password cannot connect to a Shiro protected application when using Basic authentication. The problem is in the method that splits the username and password.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Updated] (SHIRO-375) Basic authentication issue when using COLON character

Posted by "Nicolas Rougé (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHIRO-375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nicolas Rougé updated SHIRO-375:
--------------------------------

    Attachment: BasicHttpAuthenticationFilter.patch
    
> Basic authentication issue when using COLON character
> -----------------------------------------------------
>
>                 Key: SHIRO-375
>                 URL: https://issues.apache.org/jira/browse/SHIRO-375
>             Project: Shiro
>          Issue Type: Bug
>          Components: Authentication (log-in), Web
>    Affects Versions: 1.1.0, 1.2.0
>            Reporter: Nicolas Rougé
>         Attachments: BasicHttpAuthenticationFilter.patch
>
>
> A user with a COLON character in his password cannot connect to a Shiro protected application when using Basic authentication. The problem is in the method that splits the username and password.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Updated] (SHIRO-375) Basic authentication issue when using COLON character

Posted by "Nicolas Rougé (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHIRO-375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nicolas Rougé updated SHIRO-375:
--------------------------------

    Fix Version/s:     (was: 1.3.0)
                       (was: 2.0.0)
      Description: A user with a COLON character in his password cannot connect to a Shiro protected application when using Basic authentication. The problem is in the method that splits the username and password.
    
> Basic authentication issue when using COLON character
> -----------------------------------------------------
>
>                 Key: SHIRO-375
>                 URL: https://issues.apache.org/jira/browse/SHIRO-375
>             Project: Shiro
>          Issue Type: Bug
>          Components: Authentication (log-in), Web
>    Affects Versions: 1.1.0, 1.2.0
>            Reporter: Nicolas Rougé
>
> A user with a COLON character in his password cannot connect to a Shiro protected application when using Basic authentication. The problem is in the method that splits the username and password.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Commented] (SHIRO-375) Basic authentication issue when using COLON character

Posted by "Jared Bunting (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHIRO-375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13415211#comment-13415211 ] 

Jared Bunting commented on SHIRO-375:
-------------------------------------

Just changing it to {{decoded.split(":", 2)}} seems like it should be sufficient.
                
> Basic authentication issue when using COLON character
> -----------------------------------------------------
>
>                 Key: SHIRO-375
>                 URL: https://issues.apache.org/jira/browse/SHIRO-375
>             Project: Shiro
>          Issue Type: Bug
>          Components: Authentication (log-in), Web
>    Affects Versions: 1.1.0, 1.2.0
>            Reporter: Nicolas Rougé
>         Attachments: BasicHttpAuthenticationFilter.patch
>
>
> A user with a COLON character in his password cannot connect to a Shiro protected application when using Basic authentication. The problem is in the method that splits the username and password.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Commented] (SHIRO-375) Basic authentication issue when using COLON character

Posted by "Nicolas Rougé (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHIRO-375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13415189#comment-13415189 ] 

Nicolas Rougé commented on SHIRO-375:
-------------------------------------

Attached patch to fix that issue
                
> Basic authentication issue when using COLON character
> -----------------------------------------------------
>
>                 Key: SHIRO-375
>                 URL: https://issues.apache.org/jira/browse/SHIRO-375
>             Project: Shiro
>          Issue Type: Bug
>          Components: Authentication (log-in), Web
>    Affects Versions: 1.1.0, 1.2.0
>            Reporter: Nicolas Rougé
>         Attachments: BasicHttpAuthenticationFilter.patch
>
>
> A user with a COLON character in his password cannot connect to a Shiro protected application when using Basic authentication. The problem is in the method that splits the username and password.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Closed] (SHIRO-375) Basic authentication issue when using COLON character

Posted by "Les Hazlewood (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHIRO-375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Les Hazlewood closed SHIRO-375.
-------------------------------


Closing per the 1.2.1 release.
                
> Basic authentication issue when using COLON character
> -----------------------------------------------------
>
>                 Key: SHIRO-375
>                 URL: https://issues.apache.org/jira/browse/SHIRO-375
>             Project: Shiro
>          Issue Type: Bug
>          Components: Authentication (log-in), Web
>    Affects Versions: 1.1.0, 1.2.0
>            Reporter: Nicolas Rougé
>            Assignee: Jared Bunting
>             Fix For: 1.2.1, 1.3.0
>
>         Attachments: BasicHttpAuthenticationFilter.patch
>
>
> A user with a COLON character in his password cannot connect to a Shiro protected application when using Basic authentication. The problem is in the method that splits the username and password.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Comment Edited] (SHIRO-375) Basic authentication issue when using COLON character

Posted by "Jared Bunting (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHIRO-375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13415211#comment-13415211 ] 

Jared Bunting edited comment on SHIRO-375 at 7/16/12 3:15 PM:
--------------------------------------------------------------

Just changing it to decoded.split(":", 2) seems like it should be sufficient.
                
      was (Author: deraj123):
    Just changing it to {{decoded.split(":", 2)}} seems like it should be sufficient.
                  
> Basic authentication issue when using COLON character
> -----------------------------------------------------
>
>                 Key: SHIRO-375
>                 URL: https://issues.apache.org/jira/browse/SHIRO-375
>             Project: Shiro
>          Issue Type: Bug
>          Components: Authentication (log-in), Web
>    Affects Versions: 1.1.0, 1.2.0
>            Reporter: Nicolas Rougé
>         Attachments: BasicHttpAuthenticationFilter.patch
>
>
> A user with a COLON character in his password cannot connect to a Shiro protected application when using Basic authentication. The problem is in the method that splits the username and password.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira