[jira] [Comment Edited] (PDFBOX-1224) Angle units are not consistent

["Tilman Hausherr (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PDFBOX-1224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14168373#comment-14168373 ] 

Tilman Hausherr edited comment on PDFBOX-1224 at 10/11/14 9:57 PM:
-------------------------------------------------------------------

I clarified the javadoc where it wasn't mentioned. Sorry, we can't change the parameters now (I dislike it as much as you do), there are people using this method and the change would break their applications.


was (Author: tilman):
I clarified the javadoc where it wasn't mentioned. Sorry, we can't change the parameters, there are people using this method.

> Angle units are not consistent
> ------------------------------
>
>                 Key: PDFBOX-1224
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-1224
>             Project: PDFBox
>          Issue Type: Wish
>          Components: Documentation, PDModel
>    Affects Versions: 1.6.0, 2.0.0
>         Environment: ubuntu 10.04
>            Reporter: jypllx
>            Assignee: Tilman Hausherr
>            Priority: Minor
>              Labels: api-change
>             Fix For: 1.8.8, 2.0.0
>
>
> Hi Devs,
> I've noticed that the angle units are not consistent throughout pdfbox. For instance, org.apache.pdfbox.pdmodel.PDPage.setRotation() needs a angle in degrees while org.apache.pdfbox.pdmodel.edit.PDPageContentStream.setTextRotation() needs an angle in radians...
> The javadoc does not specify which units are taken as arguments.
> It would save devs a bit of time to know that all angles are to be provided in degrees or radians.
> Thanks and keep up the good work !!
> jy



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)