You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by marmbrus <gi...@git.apache.org> on 2015/12/01 02:29:33 UTC

[GitHub] spark pull request: [SPARK-11954][SQL] Encoder for JavaBeans

Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9937#discussion_r46230153
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala ---
    @@ -191,6 +193,19 @@ abstract class TreeNode[BaseType <: TreeNode[BaseType]] extends Product {
             case nonChild: AnyRef => nonChild
             case null => null
           }
    +      case m: Map[_, _] => m.mapValues {
    --- End diff --
    
    Yes, I think that is fine.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org